Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): replace chooseScalarType() callback with implicitTypes argument #5750

Merged

Conversation

timreichen
Copy link
Contributor

Changes
This PR removes the callback of chooseScalarType() and passes implicitTypes instead.

Reasoning
This allows to the inline the code of the utility function testImplicitResolving(), which is clearer to read and understand.

@timreichen timreichen requested a review from kt3k as a code owner August 20, 2024 14:23
@github-actions github-actions bot added the yaml label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (99200dc) to head (49edc92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5750      +/-   ##
==========================================
- Coverage   96.28%   96.28%   -0.01%     
==========================================
  Files         474      474              
  Lines       38383    38379       -4     
  Branches     5578     5579       +1     
==========================================
- Hits        36957    36953       -4     
  Misses       1384     1384              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timreichen timreichen changed the title refactor(yaml): remove chooseScalarType() callback with argument refactor(yaml): replace chooseScalarType() callback with implicitTypes argument Aug 20, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iuioiua iuioiua merged commit b8d3186 into denoland:main Aug 21, 2024
17 checks passed
@timreichen timreichen deleted the yaml-remove-getScalarStyle-callback branch August 21, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants