Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): inline storeMappingPair() #5779

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 22, 2024 19:48
@github-actions github-actions bot added the yaml label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.27%. Comparing base (076acf5) to head (6273bbe).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 94.87% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5779      +/-   ##
==========================================
+ Coverage   96.24%   96.27%   +0.02%     
==========================================
  Files         481      481              
  Lines       38743    38738       -5     
  Branches     5615     5615              
==========================================
+ Hits        37288    37294       +6     
+ Misses       1414     1403      -11     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Aug 22, 2024

Please rebase

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iuioiua iuioiua merged commit f14f74b into denoland:main Aug 22, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-storeMappingPair branch August 22, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants