refactor(log): align additional error messages #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligns the error messages in the `log` folder to match the style guide. denoland#5574
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5801 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 481 481
Lines 38766 38767 +1
Branches 5616 5616
=======================================
+ Hits 37303 37304 +1
Misses 1422 1422
Partials 41 41 ☔ View full report in Codecov by Sentry. |
irbull
commented
Aug 24, 2024
Comment on lines
+70
to
+76
| throw new Error(`"maxBytes" must be >= 1: received ${this.#maxBytes}`); | ||
| } | ||
| if (this.#maxBackupCount < 1) { | ||
| this.destroy(); | ||
| throw new Error("maxBackupCount cannot be less than 1"); | ||
| throw new Error( | ||
| `"maxBackupCount" must be >= 1: received ${this.#maxBackupCount}`, | ||
| ); |
There was a problem hiding this comment.
Would it be better if these checks were moved to the constructor and we could fast fail then? Or is there a reason someone would construct the object and not want to call setup, and thus want this invalid state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the error messages in the
logfolder to match the style guide.#5574