Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): replace getObjectTypeString() with isPlainObject() #5842

Conversation

timreichen
Copy link
Contributor

Changes
This PR replaces getObjectTypeString() with isPlainObject().

Reasoning
All usages are the same comparison.

@timreichen timreichen requested a review from kt3k as a code owner August 27, 2024 10:26
@github-actions github-actions bot added the yaml label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (ab2c1cd) to head (4c8097d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5842      +/-   ##
==========================================
- Coverage   96.26%   96.26%   -0.01%     
==========================================
  Files         479      479              
  Lines       38763    38753      -10     
  Branches     5623     5620       -3     
==========================================
- Hits        37314    37304      -10     
  Misses       1406     1406              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you.

@iuioiua iuioiua merged commit 29fdb0d into denoland:main Aug 28, 2024
16 checks passed
@timreichen timreichen deleted the yaml-replace-getObjectTypeString-with-isPlainObject branch August 28, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants