refactor(yaml): simplify pair construct() function
#5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5844 +/- ##
==========================================
- Coverage 96.26% 96.26% -0.01%
==========================================
Files 479 479
Lines 38751 38744 -7
Branches 5620 5619 -1
==========================================
- Hits 37305 37297 -8
- Misses 1403 1404 +1
Partials 43 43 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Aug 28, 2024
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR simplifies the pair
construct()function and adds correct types.