Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): fix sortKey error message #5873

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix(yaml): fix sortKey error message #5873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6141e55
initial commit
timreichen Aug 30, 2024
f793168
Merge branch 'main' into yaml-fix-sortKey-test
timreichen Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion yaml/_dumper_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,8 @@ export class DumperState {
} else if (this.sortKeys) {
// Something is wrong
throw new TypeError(
'"sortKeys" must be a boolean or a function: received ${typeof this.sortKeys}',
`"sortKeys" must be a boolean or a function: received ${typeof this
.sortKeys}`,
);
}

Expand Down
6 changes: 6 additions & 0 deletions yaml/stringify_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,12 @@ Deno.test("stringify() changes the key order when the sortKeys option is specifi
1.0.10: null
`,
);

assertThrows(
() => stringify(object, { sortKeys: "true" as unknown as boolean }),
TypeError,
'"sortKeys" must be a boolean or a function: received string',
);
});

Deno.test("stringify() changes line wrap behavior based on lineWidth option", () => {
Expand Down