feat(collections/unstable): support Iterable argument in takeWhile()

[Liam-Tait]

Support Iterable for collections takeWhile

#5470

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (6a4eb6c) to head (b36d8ec).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5911      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.01%     
==========================================
  Files         496      497       +1     
  Lines       39605    39621      +16     
  Branches     5841     5843       +2     
==========================================
+ Hits        38134    38147      +13     
- Misses       1429     1432       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

Nice! LGTM. @kt3k, how do you prefer we handle this, in terms of stability?

[kt3k]

how do you prefer we handle this, in terms of stability?

I'd prefer to avoid overloading with this.

How about considering this as 'refactor' or 'fix'?

[kt3k]

Or, maybe we can just land this as feat(collections/unstable) without overloading, but with note of something like Iterable input is unstable. WDYT?

[iuioiua]

Or, maybe we can just land this as feat(collections/unstable) without overloading, but with note of something like Iterable input is unstable. WDYT?

SGTM

[iuioiua]

Sorry for the delay. We're deciding how to best handle these changes that should probably be considered unstable.

[Liam-Tait]

No problem. Let me know if you need anything from me

[kt3k]

We decided to separate unstable feature from stable features more clearly (as described in #5920 ) to make it clear which part is stable and which part is not.

We are going to move this PR's implementation to unstable_take_while.ts (which will be available from JSR with the path jsr:@std/collections/unstable-take-while ) before merging, and keep the existing implementation as is.

[iuioiua]

Sorry for the delay. We've made a few tweaks, and now, LGTM! Thank you.

[kt3k]

LGTM