Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): inline serveFallback() util #5917

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 5, 2024

This PR inlines serveFallback util in file_server.

This PR also removes the handling of URIError. This error can't happen now because url is taken from request.url which should be always a valid url.

This prepares for the implementation of #5875

@github-actions github-actions bot added the http label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (fb79076) to head (523fa8d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
http/file_server.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5917      +/-   ##
==========================================
+ Coverage   96.24%   96.25%   +0.01%     
==========================================
  Files         491      491              
  Lines       39443    39436       -7     
  Branches     5811     5810       -1     
==========================================
- Hits        37961    37959       -2     
+ Misses       1438     1433       -5     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(http): inline serveFallback util refactor(http): inline serveFallback() util Sep 5, 2024
@kt3k kt3k merged commit 70f981e into denoland:main Sep 5, 2024
16 checks passed
@kt3k kt3k deleted the refactor-http-file-server branch September 5, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants