Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): invalid ipv6 hostname printed to console #5924

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Before (invalid):

http://::1:8000

After:

http://[::1]:8000

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (b3e1ebb) to head (04a6303).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
http/file_server.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5924      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.02%     
==========================================
  Files         489      489              
  Lines       39457    39459       +2     
  Branches     5824     5824              
==========================================
- Hits        37980    37977       -3     
- Misses       1433     1438       +5     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvinhagemeister marvinhagemeister changed the title fix(file_server): invalid ipv6 hostname printed to console fix(http): invalid ipv6 hostname printed to console Sep 9, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marvinhagemeister marvinhagemeister merged commit 9f19c9a into main Sep 10, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-network-address branch September 10, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants