Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(uuid/unstable): move v7 module to unstable-v7 #5937

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 11, 2024

part of #5920

This PR makes UUID v7 APIs only available from @std/uuid/unstable-v7

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should document this new approach to unstable modules.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (635a886) to head (0a60563).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5937      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         483      483              
  Lines       39415    39403      -12     
  Branches     5838     5838              
==========================================
- Hits        37968    37956      -12     
  Misses       1405     1405              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Sep 11, 2024

Can you please add this file to the super doc linter as now it's not included in uuid/mod.ts?

@iuioiua
Copy link
Contributor

iuioiua commented Sep 11, 2024

We should also probably change the title of the PR to be easier to spot for users. Like "move x to unstable-x"

@kt3k kt3k changed the title refactor(uuid): make v7 APIs explicitly unstable refactor(uuid): move UUID v7 APIs to ./unstable-v7 Sep 11, 2024
@kt3k kt3k merged commit 95d4c19 into denoland:main Sep 11, 2024
17 checks passed
@kt3k kt3k deleted the refactor-explicit-unstable-uuid-v7 branch September 11, 2024 11:23
@iuioiua iuioiua changed the title refactor(uuid): move UUID v7 APIs to ./unstable-v7 BREAKING(uuid/unstable): move v7 module to unstable-v7 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants