fix(log): ensure consistent behavior with @std/log

[iuioiua]

Fixes #5972

[iuioiua]

This test is failing because debug() doesn't actually print to the console for some reason. Need to figure out why... Any ideas, @kt3k?

[kt3k]

I think you need to call setup and override the default log level to DEBUG like the below:

import * as log from "@std/log";
log.setup({
  handlers: {
    default: new log.ConsoleHandler("DEBUG"),
  },  
  loggers: {
    default: {
      level: "DEBUG",
      handlers: ["default"],
    }   
  }
});
log.debug("debug");

The default log level is set to "INFO" here

std/log/_config.ts

Line 6 in c6d1ab2

export const DEFAULT_LEVEL = "INFO";

[iuioiua]

Are you suggesting we add that to log/debug.ts? What is the expected behavior of the following script?

import { debug } from "@std/log/debug";

debug("Hello, world!");

[kt3k]

I think the expected behavior is noop because the default log level is not low enough to log DEBUG log.

[iuioiua]

I have one more thing to check to see if that's true. But if it is true, we should remove the function.

[kt3k]

It's noop by default, however the behavior can be changed if the user want to see the debug logs. I personally don't think the removal is a good idea.

[iuioiua]

Yeah, actually, I'll just document the behavior then.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.76%. Comparing base (d902c24) to head (15e3d89).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5974   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         508      508           
  Lines       39101    39106    +5     
  Branches     5786     5786           
=======================================
+ Hits        37836    37841    +5     
  Misses       1225     1225           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

@kt3k PTAL

[kt3k]

LGTM