BREAKING(io): remove readLines()

[iuioiua]

What's changed

readLines() has been removed from @std/io.

Motivation

This change was made to help push users towards using the Streams API and @std/streams, and make design decisions about which APIs easier.

Migration guide

To migrate, pass the readable stream to toLines().

- import { readLines } from "@std/io/read-lines";
+ import { toLines } from "@std/streams/unstable-to-lines";
  import { assert } from "@std/assert/assert"

  using file = await Deno.open("README.md");

- for await (const line of readLines(file)) {
+ for await (const line of toLines(file.readable)) {
    assert(typeof line === "string");
  }

Related

Depends on #5990
Towards #5989

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (05b6d7e) to head (54c46a8).
Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5991   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         493      492    -1     
  Lines       39530    39502   -28     
  Branches     5833     5828    -5     
=======================================
- Hits        38065    38040   -25     
+ Misses       1423     1420    -3     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BlackAsLight]

In the migration guide here, you're using the using keyword to automatically close the file at the end of the scope, but that isn't needed since you're consuming the .readable property which will also automatically close the file once it hits the end of its stream.

Another person the other day on discord had a bad resource ID error thrown when doing something very similar to this, but that might have been because they weren't consuming the entire readable stream inside the same scope as the file variable.

[iuioiua]

I believe not. Consuming the .readable doesn't automatically close the file. Yeah, the issue you point to seems to be something different.

[kt3k]

LGTM