Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): use non-locale-sensitive string methods for comparison #6029

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(http): use non-locale-sensitive string methods for comparison #6029

merged 1 commit into from
Sep 20, 2024

Conversation

lionel-rowe
Copy link
Contributor

Towards #6016

Doesn't include a fix for the various text functions as it's less obvious there what the correct fix should be (e.g. should a configurable locale option be added?)

@lionel-rowe lionel-rowe requested a review from kt3k as a code owner September 20, 2024 03:27
@github-actions github-actions bot added the http label Sep 20, 2024
kt3k
kt3k approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@kt3k kt3k merged commit a1f50b4 into denoland:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel-rowe @kt3k