-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expect,internal,testing): support expect.assertions
#6032
Merged
kt3k
merged 26 commits into
denoland:main
from
eryue0220:feat/expect-assertions-count-api
Oct 25, 2024
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
18390e5
feat: expect.hasAssertion api
eryue0220 f61d3ca
Merge branch 'main' into feat/expect-assertions-api
eryue0220 dd1c658
fix: test and lint
eryue0220 60f4d84
fix: jsdoc ci
eryue0220 ba22b40
Merge branch 'main' into feat/expect-assertions-api
eryue0220 c569cfd
fix: typo
eryue0220 cd25d19
fix: ci
eryue0220 74988ae
Merge branch 'main' into feat/expect-assertions-api
eryue0220 22ce01b
feat: add expect api
eryue0220 be946a0
Apply suggestions from code review
kt3k 31e84ef
chore: add note about unstableness
kt3k 450b702
fix: bug
eryue0220 415be75
Merge branch 'main' into feat/expect-assertions-api
eryue0220 179a086
feat: add new api
eryue0220 cef4b55
feat: expect.assertions api
eryue0220 b1b90a4
Merge branch 'main' into feat/expect-assertions-count-api
eryue0220 33d9a44
chore: remove duplicate
eryue0220 bade6e5
fix: test
eryue0220 257ed06
fix: lint
eryue0220 956f022
fix: lint
eryue0220 9e4327a
Merge branch 'main' into feat/expect-assertions-count-api
iuioiua faffabd
Merge branch 'main' into feat/expect-assertions-count-api
kt3k f932dc6
fix: cr
eryue0220 f2c5910
Merge branch 'main' into feat/expect-assertions-count-api
eryue0220 0f610e1
update missing api
eryue0220 507ffe8
cancel format fix for assert
kt3k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems in jest,
expect.assertions(N)
call expects exactlyN
assertions are made. For example, the below test file fails with the error messageExpected one assertion to be called but received two assertion calls.
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've updated.