Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): register extended matchers after native matchers #6075

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

lowlighter
Copy link
Contributor

Close #6074

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (361be45) to head (0778fee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6075      +/-   ##
==========================================
- Coverage   96.75%   96.75%   -0.01%     
==========================================
  Files         508      508              
  Lines       39132    39132              
  Branches     5786     5786              
==========================================
- Hits        37864    37861       -3     
- Misses       1226     1229       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowlighter lowlighter marked this pull request as ready for review September 29, 2024 16:36
@lowlighter lowlighter requested a review from kt3k as a code owner September 29, 2024 16:36
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@kt3k kt3k merged commit ea85486 into denoland:main Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug @std/expect: extended matchers are registered before native matchers
2 participants