-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(async/unstable): accept iterator varargs in MuxAsyncIterator
#6087
feat(async/unstable): accept iterator varargs in MuxAsyncIterator
#6087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6087 +/- ##
==========================================
+ Coverage 96.75% 96.77% +0.02%
==========================================
Files 510 513 +3
Lines 39189 39250 +61
Branches 5799 5815 +16
==========================================
+ Hits 37919 37986 +67
+ Misses 1228 1222 -6
Partials 42 42 ☔ View full report in Codecov by Sentry. |
6feb809
to
0bdd293
Compare
Thanks for the PR.
I think we can extend the class and define the constructor in the subclass in |
374d2b1
to
48d5871
Compare
48d5871
to
7a7efd2
Compare
applied in |
I changed the implementation a bit to reduce the repetition. |
MuxAsyncIterator
MuxAsyncIterator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#throws: any[] = []; | ||
#signal = Promise.withResolvers<void>(); | ||
|
||
export class MuxAsyncIterator<T> extends MaxAsyncIterator_<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaxAsyncIterator_
seems to be a typo of MuxAsyncIterator_
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, true. Thanks for pointing. Can you send a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened #6096
MuxAsyncIterator
accept varargs #6086