Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(collections): add tests for filterInPlace() util #6089

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Liam-Tait
Copy link
Contributor

@Liam-Tait Liam-Tait commented Oct 4, 2024

Add testing to the uncovered filterInPlace util function. Brings collections to 100% coverage

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (065296c) to head (a6febb8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6089      +/-   ##
==========================================
+ Coverage   96.75%   96.77%   +0.01%     
==========================================
  Files         509      509              
  Lines       39175    39175              
  Branches     5795     5796       +1     
==========================================
+ Hits        37905    37911       +6     
+ Misses       1228     1222       -6     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Liam-Tait Liam-Tait marked this pull request as ready for review October 4, 2024 05:03
@Liam-Tait Liam-Tait requested a review from kt3k as a code owner October 4, 2024 05:03
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@kt3k kt3k merged commit 0312678 into denoland:main Oct 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants