Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cbor): replace toByteStream function in common with import from @std/streams #6107

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

BlackAsLight
Copy link
Contributor

This pull request replaces the toByteStream function that existed in ./common.ts with the identical one that was recently merged into @std/streams.

This pull request also sorts all the imports alphabetically.

@BlackAsLight BlackAsLight requested a review from kt3k as a code owner October 11, 2024 07:45
@github-actions github-actions bot added the cbor label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (a4cd8af) to head (9273ba5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6107      +/-   ##
==========================================
+ Coverage   96.55%   96.56%   +0.01%     
==========================================
  Files         534      534              
  Lines       40589    40550      -39     
  Branches     6093     6084       -9     
==========================================
- Hits        39190    39158      -32     
+ Misses       1355     1347       -8     
- Partials       44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title chore: replace toByteStream function in common with import from @std/streams refactor(cbor): replace toByteStream function in common with import from @std/streams Oct 13, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 47afc26 into denoland:main Oct 13, 2024
20 checks passed
@BlackAsLight BlackAsLight deleted the cbor_common branch October 13, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants