Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(streams): rest arguments not being asserted in docs #6155

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

efekrskl
Copy link
Contributor

Currently, rest arguments are not being asserted when lint:docs is run. This PR fixes the issue and adds missing @param field to docs.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (8c9b4c6) to head (344431f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6155      +/-   ##
==========================================
+ Coverage   96.50%   96.51%   +0.01%     
==========================================
  Files         536      536              
  Lines       40744    40765      +21     
  Branches     6111     6118       +7     
==========================================
+ Hits        39320    39346      +26     
+ Misses       1379     1375       -4     
+ Partials       45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title fix: rest arguments not being asserted in docs docs(streams): rest arguments not being asserted in docs Oct 29, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks!

@kt3k kt3k merged commit ff6037a into denoland:main Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants