Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): do not serve dot files when showDotfiles=false #6180

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 12, 2024

Currently file server serves dot files even when showDotfiles=false specified. This PR changes it to not serve dot files when showDotfiles=false.

@kt3k kt3k requested a review from bartlomieju November 12, 2024 06:10
@github-actions github-actions bot added the http label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (69858cf) to head (4b109fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6180   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         535      535           
  Lines       41281    41285    +4     
  Branches     6163     6165    +2     
=======================================
+ Hits        39833    39837    +4     
  Misses       1404     1404           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title fix(http): do not serve dotfile when showDotfile=false fix(http): do not serve dot files when showDotfiles=false Nov 12, 2024
@kt3k kt3k merged commit 9607eb8 into denoland:main Nov 12, 2024
20 checks passed
@kt3k kt3k deleted the do-not-show-dotfiles branch November 12, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants