Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): rewrite promptSelect() clear commands #6215

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner November 27, 2024 12:03
@github-actions github-actions bot added the cli label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (b86d762) to head (8b0927c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6215   +/-   ##
=======================================
  Coverage   96.52%   96.53%           
=======================================
  Files         534      534           
  Lines       40922    40924    +2     
  Branches     6131     6131           
=======================================
+ Hits        39499    39504    +5     
+ Misses       1381     1378    -3     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kt3k kt3k changed the title chore(cli): rewrite promptSelect() clear commands refactor(cli): rewrite promptSelect() clear commands Nov 28, 2024
@kt3k kt3k merged commit 9904412 into denoland:main Nov 28, 2024
19 checks passed
@timreichen timreichen deleted the cli-rewrite-clear-commands branch November 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants