Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): add tests for promptSecret() #6256

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

timreichen
Copy link
Contributor

Seems like promptSecret() is stable but not covered by any tests. I think that should be avoided in the future.

@timreichen timreichen requested a review from kt3k as a code owner December 12, 2024 09:08
@github-actions github-actions bot added the cli label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (cc9a7c0) to head (fd50289).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6256   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         536      537    +1     
  Lines       41179    41245   +66     
  Branches     6175     6194   +19     
=======================================
+ Hits        39735    39800   +65     
- Misses       1401     1402    +1     
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/prompt_secret.ts Outdated Show resolved Hide resolved
@kt3k kt3k changed the title feat(cli): add tests for promptSecret() test(cli): add tests for promptSecret() Dec 16, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@kt3k kt3k merged commit 16c4136 into denoland:main Dec 16, 2024
19 checks passed
@timreichen timreichen deleted the add-prompt-secret-tests branch December 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants