Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/unstable): promptSelect() add isTerminal() check #6264

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(cli/unstable): promptSelect() add isTerminal() check #6264

merged 1 commit into from
Dec 16, 2024
+57 −13

Conversation

timreichen
Copy link
Contributor

ref #6257

@timreichen timreichen requested a review from kt3k as a code owner December 13, 2024 22:09
@github-actions github-actions bot added the cli label Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.50%. Comparing base (283cf34) to head (5ccae4f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cli/unstable_prompt_select.ts 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6264   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files         536      536           
  Lines       41179    41182    +3     
  Branches     6175     6181    +6     
=======================================
+ Hits        39734    39741    +7     
+ Misses       1403     1399    -4     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title chore(cli): promptMultipleSelect() add isTerminal() check fix(cli/unstable): promptSelect() add isTerminal() check Dec 16, 2024
kt3k
kt3k approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit d71adda into denoland:main Dec 16, 2024
19 checks passed
@timreichen timreichen deleted the promptSelect()-add-isTerminal()-check branch December 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k