Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): remove parseArgs() console logs from examples #6268

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

timreichen
Copy link
Contributor

This PR removes all parseArgs() console logs and adds a constant declaration instead. This is how it is done in other examples and also prevents logs when calling deno task test.

@timreichen timreichen requested a review from kt3k as a code owner December 14, 2024 00:21
@github-actions github-actions bot added the cli label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (283cf34) to head (f067755).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6268      +/-   ##
==========================================
- Coverage   96.49%   96.35%   -0.14%     
==========================================
  Files         536      542       +6     
  Lines       41179    41372     +193     
  Branches     6175     6201      +26     
==========================================
+ Hits        39734    39864     +130     
- Misses       1403     1465      +62     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title chore(cli): remove parseArgs() console logs docs(cli): remove parseArgs() console logs from examples Dec 16, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4763ec0 into denoland:main Dec 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants