Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(md5): throw TypeError for wrong type #698

Merged
merged 1 commit into from
Feb 9, 2021
Merged

refactor(md5): throw TypeError for wrong type #698

merged 1 commit into from
Feb 9, 2021

Conversation

hong4rc
Copy link
Contributor

@hong4rc hong4rc commented Feb 3, 2021

Use TypeError is a good option for a value is not of the expected type

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ry ry merged commit 20a7563 into denoland:main Feb 9, 2021
@nayeemrmn
Copy link
Contributor

I don't see why we have runtime type checking here at all, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hong4rc @CLAassistant @nayeemrmn @ry