fix(path/glob): Fixed array type error in glob.ts #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Minimal replicability**
tsconfig.json:
```json
{
"compilerOptions": {
"noImplicitAny": false
}
}
```
example.ts:
```typescript
import "https://deno.land/std@0.99.0/path/glob.ts";
```
Running `deno run --config ./tsconfig.json ./example.ts` will result in the following errors:
<details>
<summary>Error log</summary>
```error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("+");
~~~
at https://deno.land/std@0.99.0/path/glob.ts:219:25
TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("@");
~~~
at https://deno.land/std@0.99.0/path/glob.ts:226:25
TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("?");
~~~
at https://deno.land/std@0.99.0/path/glob.ts:234:27
TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("!");
~~~
at https://deno.land/std@0.99.0/path/glob.ts:244:25
TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("BRACE");
~~~~~~~
at https://deno.land/std@0.99.0/path/glob.ts:250:25
TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
groupStack.push("*");
~~~
at https://deno.land/std@0.99.0/path/glob.ts:269:27
Found 6 errors.
```
</details>
**Reason**
I believe this is caused by `const groupStack = [];` which is being inferred as `never[]`.
**Fix**
I added `string[]` to `groupStack`.
**Note:** Just started using Deno so possibly I've misconfigured Deno.
|
|
PatrickShaw
changed the title
PatrickShaw
changed the title
PatrickShaw
added a commit
to the-monorepo/nexus
that referenced
this pull request
Jun 23, 2021
kt3k
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi!
This PR fixes the following error that I've been experiencing with glob.ts:
Error log
Minimal replicability
tsconfig.json:
{ "compilerOptions": { "noImplicitAny": false } }example.ts:
Running
deno run --config ./tsconfig.json ./example.tswill result in the error log above:Reason
I believe this is caused by
const groupStack = [];which is being inferred asnever[].Fix
I added
string[]togroupStack.Tried compiling the file directly with this change and it seems to fix the problem. Happy to do a full run of deno_std tests locally if need be (as per https://github.com/denoland/deno_std#contributing) but I'm assuming this change is pretty safe :)