Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing won't show status for test cases with same name in different steps #656

Closed
KyleJune opened this issue Apr 16, 2022 · 0 comments · Fixed by denoland/deno#20297
Closed

Testing won't show status for test cases with same name in different steps #656

KyleJune opened this issue Apr 16, 2022 · 0 comments · Fixed by denoland/deno#20297
Assignees
@kitsonk
Labels
bug Something isn't working dx testing Running test using LSP

Comments

@KyleJune
Copy link

Describe the bug

Tests with a name that matches another test case nested in another test step currently just show a grey circle making it unclear what the status of the test case is.

To Reproduce

  1. Open https://deno.land/std@0.135.0/testing/bdd_test.ts and run tests

Expected behavior

The tests should all show green check marks.

Screenshots

image

Versions

vscode: 1.66.2 deno: 1.20.6 extension: v3.12.0
@lucacasonato lucacasonato added the bug Something isn't working label Apr 16, 2022
@bartlomieju bartlomieju added testing Running test using LSP dx labels Jul 10, 2023
@nayeemrmn nayeemrmn mentioned this issue Aug 26, 2023
Merged
bartlomieju pushed a commit to denoland/deno that referenced this issue Aug 27, 2023
@nayeemrmn
fix(lsp/testing): use full ancestry to compute static id of step (#20297
e1fe315 
)

Fixes denoland/vscode_deno#656.

Test steps were ID'd by a checksum of `[origin, level, step_name]` which
is incorrect. Now it's `[origin, ...ancestor_names, step_name]`.
bartlomieju pushed a commit to denoland/deno that referenced this issue Aug 31, 2023
@nayeemrmn @bartlomieju
fix(lsp/testing): use full ancestry to compute static id of step (#20297
eb83475 
)

Fixes denoland/vscode_deno#656.

Test steps were ID'd by a checksum of `[origin, level, step_name]` which
is incorrect. Now it's `[origin, ...ancestor_names, step_name]`.
@snyk-io snyk-io bot mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
bug Something isn't working dx testing Running test using LSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp/testing): use full ancestry to compute static id of step nayeemrmn/deno
4 participants
@kitsonk @KyleJune @lucacasonato @bartlomieju