Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify markdownlint #4628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify markdownlint #4628

wants to merge 2 commits into from

Conversation

sisrfeng
Copy link

@sisrfeng sisrfeng commented Oct 7, 2023

related issue: #4627

w0rp
w0rp requested changes Nov 19, 2023
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the []() syntax for this while still fixing the hyperlinks? The custom ALE CI checks will demand this format.

@sisrfeng
Copy link
Author

What about now?

@w0rp
Copy link
Member

w0rp commented Dec 10, 2023

Have a look at the CI results. You can run the checks locally. Check :help ale-dev. The Vim text documentation needs to match the Markdown documentation.

@stale Stale
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

@stale stale bot added the stale PRs/Issues no longer valid label Mar 17, 2024
@stale stale bot closed this Apr 22, 2024
@w0rp w0rp reopened this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
stale PRs/Issues no longer valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisrfeng @w0rp