Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image-upgrade, test suite 'suite_group_clean_config', and test case 'test_switch_reload_all' #10

Closed
wants to merge 2 commits into from

Conversation

alisaycl96
Copy link

@alisaycl96 alisaycl96 commented Oct 12, 2021

  1. The test case 'test_switch_reload_all' fails due to the incorrect version of python library "progressbar". Update the Requirements.txt.
  2. Fix the image-upgrade by modifying the script name from "onie-select" into "dent_boot_select" in OsInstallerOnieSelect.py.
  3. Fix the test suite "suite_group_clean_config" by deleting infra_sw1_KEEPALIVED_CONF and taking out the unnecessary code of staging file in test_clean_config.py.

Signed-off-by: Alisa Li alisa_li@accton.com

rothcar
rothcar previously approved these changes Oct 14, 2021
Copy link
Collaborator

@rothcar rothcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test suite still had some leftover hacks from our lab setup, thanks for catching that.

isgmano
isgmano previously approved these changes Oct 24, 2021
rothcar
rothcar previously approved these changes Oct 26, 2021
…ents.txt

  2) Fix the image-upgrade by modifying the script name from 'onie-select' into 'dent_boot_select'
  3) Fix the test suite 'suite_group_clean_config' by deleting 'infra_sw1_KEEPALIVED_CONF' and taking out the unnecessary code of staging file in 'test_clean_config.py'

  Signed-off-by: Alisa Li alisa_li@accton.com

Signed-off-by: Alisa Li <alisa_li@accton.com>
@robimarko
Copy link

LGTM, just remove the merge commit

@alisaycl96
Copy link
Author

This commit has been added to the new PR#11, so closed this one.

@alisaycl96 alisaycl96 closed this Nov 11, 2021
mgheorghe pushed a commit that referenced this pull request Aug 8, 2023
* Fix Password Policy for CI (#384)



Fix Dockerfile Run Naming



* Fix Docker Container Naming



---------

Signed-off-by: fkwilken <fkwilken@gmail.com>
hubogee pushed a commit to hubogee/testing that referenced this pull request Aug 22, 2023
* Fix Password Policy for CI (dentproject#384)



Fix Dockerfile Run Naming



* Fix Docker Container Naming



---------

Signed-off-by: fkwilken <fkwilken@gmail.com>
hubogee added a commit to hubogee/testing that referenced this pull request Aug 22, 2023
* Updated testbed files and Network interfaces files

Signed-off-by: hubogee <hubogee@gmail.com>

* Optimize VPort Addition, Protocol Timing (dentproject#386)

Signed-off-by: fkwilken <fkwilken@gmail.com>

* Pr fix dockerfile (dentproject#10) (dentproject#388)

* Fix Password Policy for CI (dentproject#384)



Fix Dockerfile Run Naming



* Fix Docker Container Naming



---------

Signed-off-by: fkwilken <fkwilken@gmail.com>

* Added testbed device details: PDU, Mac, cpu architecture

Signed-off-by: hubogee <hubogee@gmail.com>

---------

Signed-off-by: hubogee <hubogee@gmail.com>
Signed-off-by: fkwilken <fkwilken@gmail.com>
Co-authored-by: Francisco <74398368+fkwilken@users.noreply.github.com>
hubogee added a commit to hubogee/testing that referenced this pull request Aug 22, 2023
* Updated testbed files and Network interfaces files

Signed-off-by: hubogee <hubogee@gmail.com>

* Optimize VPort Addition, Protocol Timing (dentproject#386)

Signed-off-by: fkwilken <fkwilken@gmail.com>

* Pr fix dockerfile (dentproject#10) (dentproject#388)

* Fix Password Policy for CI (dentproject#384)

Fix Dockerfile Run Naming

* Fix Docker Container Naming

---------

Signed-off-by: fkwilken <fkwilken@gmail.com>

* Added testbed device details: PDU, Mac, cpu architecture

Signed-off-by: hubogee <hubogee@gmail.com>

---------

Signed-off-by: hubogee <hubogee@gmail.com>
Signed-off-by: fkwilken <fkwilken@gmail.com>
Co-authored-by: Francisco <74398368+fkwilken@users.noreply.github.com>
Signed-off-by: hubogee <hubogee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants