Skip to content

Commit

Permalink
Add waits to dropdown selectors
Browse files Browse the repository at this point in the history
  • Loading branch information
@ThorntonMatthew
ThorntonMatthew committed Aug 3, 2023
1 parent 8b1c7de commit 056d8dc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion spec/feature/hearings/assign_hearings_table_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ def navigate_to_ama_tab
it "filters are correct, and filter as expected" do

Check failure on line 449 in spec/feature/hearings/assign_hearings_table_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 9) 

Assign Hearings Table Hearing Request Type column Legacy Veterans waiting queue Filter by Hearing Type column filters are correct, and filter as expected

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
step "navigate to St. Petersburg legacy veterans tab" do
visit "hearings/schedule/assign"
click_dropdown(text: "St. Petersburg")
click_dropdown(text: "St. Petersburg", wait: 3)
click_button("Legacy Veterans Waiting", exact: true)
end

Expand Down
4 changes: 2 additions & 2 deletions spec/feature/hearings/convert_hearing_request_type/edit_hearsched_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def change_request_type(appeal, request_type, ro_message)
visit "queue/appeals/#{video_appeal.uuid}"

# Select the Convert hearing to Central action
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_CENTRAL.label)
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_CENTRAL.label, wait: 3)

# CHeck the Modal content and confirm the conversion
expect(page).to have_content("Central Office")
Expand Down Expand Up @@ -292,7 +292,7 @@ def change_request_type(appeal, request_type, ro_message)
convert_label = COPY::CONVERT_HEARING_TYPE_DEFAULT_REGIONAL_OFFICE_TEXT
visit "queue/appeals/#{central_office_appeal.uuid}"

click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_VIDEO.label)
click_dropdown(text: Constants.TASK_ACTIONS.CHANGE_HEARING_REQUEST_TYPE_TO_VIDEO.label, wait: 3)

# CHeck the Modal content and confirm the conversion
expect(page).to have_content(convert_label)
Expand Down
6 changes: 3 additions & 3 deletions spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ def format_hearing_day(hearing_day, detail_label = nil, total_slots = 0)
scenario "can schedule a veteran without an error" do
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("AMA Veterans Waiting", exact: true)
click_on "Bob"

Expand All @@ -692,7 +692,7 @@ def format_hearing_day(hearing_day, detail_label = nil, total_slots = 0)
scenario "should not see room displayed under Available Hearing Days and Assign Hearing Tabs" do

Check failure on line 692 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 2) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature disabled with schedule direct to video/virtual feature enabled behaves like scheduling an AMA hearing and room is null should not see room displayed under Available Hearing Days and Assign Hearing Tabs

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling an AMA hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1063

Check failure on line 692 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 1) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature enabled behaves like scheduling an AMA hearing and room is null should not see room displayed under Available Hearing Days and Assign Hearing Tabs

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling an AMA hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1098
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("AMA Veterans Waiting", exact: true)
click_on "Bob"

Expand Down Expand Up @@ -737,7 +737,7 @@ def format_hearing_day(hearing_day, detail_label = nil, total_slots = 0)
scenario "can schedule a veteran without an error" do

Check failure on line 737 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 10) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature enabled behaves like scheduling a Legacy hearing and room is null can schedule a veteran without an error

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling a Legacy hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1100

Check failure on line 737 in spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb

View workflow job for this annotation

GitHub Actions / caseflow_rspec_job (12, 9) 

Schedule Veteran For A Hearing with an authorized user with enable_time_slots feature disabled with schedule direct to video/virtual feature enabled behaves like scheduling a Legacy hearing and room is null can schedule a veteran without an error

Failure/Error: dropdown.sibling(".cf-select__menu")&.text&.split("\n") || []

Capybara::ElementNotFound:
  Unable to find css ".cf-select__menu" that is a sibling of visible css ".cf-select__control"
Shared Example Group: "scheduling a Legacy hearing" called from ./spec/feature/hearings/schedule_veteran/build_hearsched_spec.rb:1065
visit "hearings/schedule/assign"

click_dropdown(text: "Denver")
click_dropdown(text: "Denver", wait: 3)
click_button("Legacy Veterans Waiting", exact: true)
click_on "Bob Smith"

Expand Down

0 comments on commit 056d8dc

Please sign in to comment.