Add argument for call within sync_review_job.rb and minor refactor

app/jobs/sync_reviews_job.rb

@@ -58,7 +58,7 @@ def perform_decision_rating_issues_syncs(limit)
 
   def reprocess_decision_documents(limit)
     DecisionDocument.requires_processing.limit(limit).each do |decision_document|
-      ProcessDecisionDocumentJob.perform_later(decision_document.id)
+      ProcessDecisionDocumentJob.perform_later(decision_document.id, decision_document.for_contested_claim?)
     end
   end
 end

app/models/decision_document.rb

@@ -64,13 +64,8 @@ def submit_for_processing!(delay: processing_delay)
       # Below we're grabbing the boolean value at this point in time.
       # This will act as a point of truth that wont be affected by the
       # async behavior of the outcode function due to triggering jobs.
-      case appeal_type
-      when "Appeal"
-        contested = appeal.contested_claim?
-      when "LegacyAppeal"
-        contested = appeal.contested_claim
-      end
-      ProcessDecisionDocumentJob.perform_later(id, contested, mail_package)
+
+      ProcessDecisionDocumentJob.perform_later(id, for_contested_claim?, mail_package)
     end
   end
 
@@ -127,6 +122,15 @@ def all_contention_records(epe)
     contention_records(epe)
   end
 
+  def for_contested_claim?
+    case appeal_type
+    when "Appeal"
+      return appeal.contested_claim?
+    when "LegacyAppeal"
+      return appeal.contested_claim
+    end
+  end
+
   private
 
   attr_reader :mail_package

spec/jobs/sync_reviews_job_spec.rb

@@ -143,7 +143,7 @@
           SyncReviewsJob.perform_now
         end.to have_enqueued_job(
           ProcessDecisionDocumentJob
-        ).with(decision_document_needs_reprocessing.id).exactly(:once)
+        ).with(decision_document_needs_reprocessing.id, false).exactly(:once)
       end
     end
   end