Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature/appeals 44915.release/fy24 q4.5.0 (#22845)
* Add in appeals_tied_to_non_ssc_avljs methods and SQL * Update case_docket.rb * Update case_docket.rb * APPEALS-51263 added the lever to the seeds file (#22149) * Amybids/appeals 51263 (#22169) * APPEALS-51263 added the lever to the seeds file * APPEALS-51263 test cleanup for case_docket, case_distribution_levers_controller_spec and case_distribution_test_data_spec.rb * APPEALS-51262 (#22176) * creates trait in factory for non_ssc_avlj user * updates user in user factory with new traits in staff factory * adds randomized judge method * replaces user create with a vacols staff create and limits css_id to 12 using slogid, adds judge_role for active smemgrp * updates naming --------- Co-authored-by: Michael Beard <michael.beard@va.gov> * APPEALS-45232. Added table in the DB and added requested columns (#22223) * APPEALS-45232. Added table in the DB and added requested columns * APPEALS-45232. Fix lint issues * APPEALS-45232. Fixed the class name * APPEALS-45232. Updated the column names from feedback --------- Co-authored-by: SHarshain <spoosa@razortalent.com> * Sharsha/appeals 45200 (#22233) * APPEALS-45200. create Return Appeals tied to non-SSC AVLJs job * APPEALS-45200. WIP --------- Co-authored-by: SHarshain <spoosa@razortalent.com> * Chrisbdetlef/appeals 45208 (#22305) * Framework for seeds * Add comments and fill in further methods * Further shared dev work * Update names * Expanded possible functions * More functions for shared work * Combine everyones work into main branch * Combined work - testing * Combined work - testing complete * rubocop fix --------- Co-authored-by: Christopher Detlef <> * APPEALS-45202.Added button to trigger the job and return the appeals (#22375) Co-authored-by: SHarshain <spoosa@razortalent.com> * Updates slack_service.rb to include local/demo console printout message (#22343) * APPEALS-51487 Location 63 Query (#22398) * APPEALS-51487 Location 63 Query * fix naming and change query * Working code * Add 2 day limit to query * Remove commented out code * Fix lint issues * Remove binding.pry --------- Co-authored-by: Christopher Detlef <> * APPEALS-45248 ACD Controls Test Page Alerts for Run Seed Fils and Case Movement Section Buttons (#22386) * APPEALS-45248 Add success banner alerts to Run seed files and case movement section buttons * APPEALS-45248 add fail job button and refactored code * Ricky/APPEALS-45204 (#22373) * Added button, and initial csv generation of appeals tied to non ssc avljs * WIP. APPEALS-45204 tweaks to Push data into CSV * APPEALS-45204. fix the method error * APPEALS-45204. Lint fix * Updated query to fetch hearing and grab non ssc avlj names properly * Fixed outstanding issues and cleaned up seeds * implements new hearing_judge, separates assigned_avlj and signing_avlj * Fixed linting issues and other clean up --------- Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: Michael Beard <michael.beard@va.gov> * Ricky/APPEALS-45204 (#22452) * Added button, and initial csv generation of appeals tied to non ssc avljs * WIP. APPEALS-45204 tweaks to Push data into CSV * APPEALS-45204. fix the method error * APPEALS-45204. Lint fix * Updated query to fetch hearing and grab non ssc avlj names properly * Fixed outstanding issues and cleaned up seeds * implements new hearing_judge, separates assigned_avlj and signing_avlj * Fixed linting issues and other clean up * Updated name of CSV download button --------- Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: Michael Beard <michael.beard@va.gov> * Chrisbdetlef/appeals 54138 (#22460) * APPEALS-51487 Location 63 Query * fix naming and change query * Working code * Add 2 day limit to query * Remove commented out code * Fix lint issues * Remove binding.pry * APPEALS-54138 Add button to seed non-SSC AVLJs --------- Co-authored-by: Christopher Detlef <> * Fix for routing table (#22466) Co-authored-by: Christopher Detlef <> * Chrisbdetlef/appeals 54138.1 (#22486) * Fix for routing table * Randomly select docket id number --------- Co-authored-by: Christopher Detlef <> * Updated query to correctly grab seed data (#22489) Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> * Ricky/APPEALS-51260 (#22497) * Updated query to correctly grab seed data * Replaced AOD and CAVC fields with Priority, fixed csv file name --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> * APPEALS-54884. spec fix push priority appeals to judges job (#22505) Co-authored-by: SHarshain <spoosa@razortalent.com> * exchanges spaces for hyphens, updates method to filter by unique veteran file numbers (#22524) * updates seed file names to match AC and adds hyphens instead of spaces (#22530) * Chrisbdetlef/appeals 54152 (#22531) * APPEALS-54152 Move Appeals to loc 63 * Fix minor issues with the query and data displayed in the CSV * APPEALS-54152 Move qualifying appeals to Loc 63 --------- Co-authored-by: Christopher Detlef <> * APPEALS-54152.1 Fix issues with the process of making and moving appeals tied to nonSSC AVLJs (#22541) Co-authored-by: Christopher Detlef <> * Chrisbdetlef/appeals 54152.1 (#22544) * APPEALS-54152.1 Fix issues with the process of making and moving appeals tied to nonSSC AVLJs * TEST ONLY DO NOT MERGE --------- Co-authored-by: Christopher Detlef <> * Chrisbdetlef/appeals 54152.2 (#22554) * APPEALS-54152.2 Change movement to loc 63 to 2 per AVLJ * Fix lint issues and errors * Remove artifact code * Fix errors --------- Co-authored-by: Christopher Detlef <> * Code changes to account for duplicates from base query (#22582) * Code changes to account for duplicates from base query * Add warning to join constant * Fix issue with empty array --------- Co-authored-by: Christopher Detlef <> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> * mbeard/APPEALS-45203 (#22565) * refactored to include new move_qualifying_appeals method * updated filtered methods and eligible appeals, moved appeals variables * moves logic for eligible and moved appeals into new method * cleaned up filter_method, simplified other methods * updates to failing test * ensures appeals isn't nil when job is complete * Fix the last name issue on loc 63 CSV (#22591) Co-authored-by: Christopher Detlef <> * APPEALS-45248 v2 ACD Controls Test Page Alerts for Run Seed Fils and Case Movement Section Buttons (#22449) * APPEALS-45248 Add success banner alerts to Run seed files and case movement section buttons * APPEALS-45248 add fail job button and refactored code * APPEALS-45248 address ac2 of the story and set timer for banner alerts * APPEALS-45248-v2 update button verbiage * APPEALS-54061 added collapsible table to see the 15 latest ReturnLegacyAppealsToBoard log on test page * APPEALS-54061 refactor code to address modified AC in the story * fixed linting issues * some lint fixes --------- Co-authored-by: 631966 <amy.detwiler@va.gov> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> * APPEALS-APPEALS-55680 added nil checking to the return legacy to appe… (#22607) * APPEALS-APPEALS-55680 added nil checking to the return legacy to appeals to board job * APPEALS-55680 finish job if no moved appeals * APPEALS-55680 made the no record slack message into an array * APPEALS-55680 fixed rubocop issues * mbeard/APPEALS-55179 (#22615) * adds constants and updates method to use constant * changes lever_group * APPEALS-55179. Fix the query and update the Constant value * updates method and puts constants to lowercase * adds nonsscavlj_number_of_appeals_to_move to failing spec array --------- Co-authored-by: SHarshain <spoosa@razortalent.com> * mbeard/APPEALS-45203 (#22626) * removes avljs from the slack message * updates to slack messages * APPEALS-54290 CSV for all tied VLJ cases (#22624) Co-authored-by: Christopher Detlef <> * APPEALS-56033 fixed duplicate, nil, and error handling * APPEALS-56033 fixed duplicate, nil, and error handling (#22630) * APPEALS-56033 fix job running on frontend * APPEALS-56033 fixed linting error * Amybids/appeals 56033 (#22635) * APPEALS-56033 fixed duplicate, nil, and error handling * APPEALS-56033 fix job running on frontend * APPEALS-56033 fixed linting error * Fix off by 1 error for returntoboard job (#22648) * Fix off by 1 error for returntoboard job * removed the extraneous space * refactored the variables * refactored variable names to fix rubocop issues --------- Co-authored-by: Christopher Detlef <> Co-authored-by: 631966 <amy.detwiler@va.gov> * mbeard/APPEALS-55660 (#22653) * Updates test coverage for full perform method * fixed linting issues * updates to receive and return a number of appeals moved * updates value from 10 to 2 moved appeals * adds trait to factory and lever to push priority spec * APPEALS-56980 Fix for .perform_later functionality in higher environm… (#22671) * APPEALS-56980 Fix for .perform_later functionality in higher environments * Remove lines of code that aren't needed and add built in checker * Fix 1 of 2 errors * Move local variables out of intialize or callback methods --------- Co-authored-by: Christopher Detlef <> * APPEALS-55158 removed the skipped specs to make the test suite pass (#22651) * Chrisbdetlef/appeals 54290 (#22647) * APPEALS-54290 CSV for all tied VLJ cases * Added support for AMA appeals * Fix linting issues --------- Co-authored-by: Christopher Detlef <> * ricky/APPEALS-55123 (#22617) * Added VLJ and Inactive Non-SSC AVLJ seeds * Updated seeds to include signed and unsigned AMA appeals * Fixed AMA hearing to not error on creation --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com> * Added docket back because sym doesn't provide the same information * APPEALS-57322 Add logging for Not Ready to Distribute appeals (#22722) * APPEALS-57322 Add logging for Not Ready to Distribute appeals * Remove binding pry --------- Co-authored-by: Christopher Detlef <> * Change the button label (#22723) * Change the button label * Remove binding pry --------- Co-authored-by: Christopher Detlef <> * fix appeals ready to distribute * Change the name of the SSC AVLJ (#22728) * Change the name of the SSC AVLJ * Remove binding pry --------- Co-authored-by: Christopher Detlef <> * APPEALS-57428. Update job log when job completes with no records (#22736) * APPEALS-57428. Update job log when job completes with no records * APPEALS-57428. Job stops if the returned appeals is nil --------- Co-authored-by: SHarshain <spoosa@razortalent.com> * reverted work so that the legacy rows show up as NA (#22744) * Sharsha/tes branch master (#22772) * APPEALS-57428.Update job log when job completes with no records * Upmerge master * spec fix * fixed some bug errors * fixed linting issue --------- Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: 631966 <amy.detwiler@va.gov> * APPEALS-57711. fix the ama_rows logc (#22775) Co-authored-by: SHarshain <spoosa@razortalent.com> * APPEALS-57801 Fix merging error (#22781) * APPEALS-57801 Fix merging error * rubocop fix --------- Co-authored-by: Christopher Detlef <> * APPEALS-57058. Automated Tests for the Queries (#22791) * APPEALS-57058. WIP - check loc_63_appeals * APPEALS-57058. more test coverage --------- Co-authored-by: SHarshain <spoosa@razortalent.com> * Ricky/APPEALS-57057 (#22801) * Created outline for CSV test for appeals tied to non ssc avljs * Updated rspec for appeals tied to non ssc avlj to have full coverage * Created initial spec file for appeeals tied to avljs and vljs query * Added testing support appeals_tied_to_avljs_and_vljs_query * Updated testing on appeals_tied_to_avlj_and_vljs * Updated framework on location 63 appeals CSV rspec testing * Fixed base test for appeals in location 63 CSV * Updated data structure to properly check test * Updated location 63 CSV to have full coverage * Fixed linting * Chrisbdetlef/appeals 55660 (#22798) * Psuedo code for specs * Framework for tests * Split work * APPEALS-55660. Test expansion (#22714) Co-authored-by: SHarshain <spoosa@razortalent.com> * APPEALS-55660 Expanded test coverage for ReturnToBaordJob * Combine work * Fix linting and add some error handling --------- Co-authored-by: Christopher Detlef <> Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> * Chrisbdetlef/appeals 58192 (#22832) * APPEALS-58192 Fix location 63 query test * Fix rubocop issues --------- Co-authored-by: Christopher Detlef <> * updated migration for rails 6 --------- Co-authored-by: Matthew Roth <roth_matthew@bah.com> Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com> Co-authored-by: Michael Beard <michael.beard@va.gov> Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com> Co-authored-by: Michael Beard <131783726+mbeardy@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
- Loading branch information