42566 - fix checkbox across different pages (#23075)

* fix checkbox across different pages * Database realtion fix * Lint fixes --------- Co-authored-by: divyadasari-va <divya.dasari@va.gov> Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
department-of-veterans-affairs · Oct 3, 2024 · 45765e5 · 45765e5
1 parent 5016649
commit 45765e5
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/app/controllers/correspondence_details_controller.rb b/app/controllers/correspondence_details_controller.rb
@@ -150,9 +150,12 @@ def save_correspondence_appeals
       end
     end
     if params[:unselected_appeal_ids].present?
-      @correspondence.correspondence_appeals
+      correspondence_appeals_to_delete = @correspondence.correspondence_appeals
         .where(appeal_id: params[:unselected_appeal_ids])
-        .delete_all
+
+      CorrespondencesAppealsTask.where(correspondence_appeal_id: correspondence_appeals_to_delete.pluck(:id)).delete_all
+
+      correspondence_appeals_to_delete.delete_all
     end
     respond_to do |format|
       format.html

diff --git a/app/models/correspondence_appeal.rb b/app/models/correspondence_appeal.rb
@@ -3,6 +3,6 @@
 class CorrespondenceAppeal < ApplicationRecord
   belongs_to :correspondence
   belongs_to :appeal
-  has_many :correspondences_appeals_tasks
+  has_many :correspondences_appeals_tasks, dependent: :destroy
   has_many :tasks, through: :correspondences_appeals_tasks
 end
diff --git a/client/app/queue/CaseListTable.jsx b/client/app/queue/CaseListTable.jsx
@@ -27,7 +27,8 @@ class CaseListTable extends React.PureComponent {
   getKeyForRow = (rowNumber, object) => object.id;
 
   toggleCheckboxState = (appealId) => {
-    const checked = this.props?.taskRelatedAppealIds.includes(Number(appealId));
+    const appealsToConsider = this.props?.initialAppealIds || this.props?.taskRelatedAppealIds;
+    const checked = appealsToConsider.includes(Number(appealId));
 
     return checked ? this.props?.userAccess !== 'admin_access' : false;
   };

diff --git a/client/app/queue/correspondence/details/CorrespondenceDetails.jsx b/client/app/queue/correspondence/details/CorrespondenceDetails.jsx
@@ -452,7 +452,8 @@ const CorrespondenceDetails = (props) => {
                 appeals={appealsToDisplay}
                 paginate
                 showCheckboxes
-                taskRelatedAppealIds={disableSubmitButton ? selectedAppeals : initialSelectedAppeals}
+                taskRelatedAppealIds={selectedAppeals}
+                initialAppealIds={initialSelectedAppeals}
                 enableTopPagination
                 userAccess={userAccess}
                 checkboxOnChange={appealCheckboxOnChange}