Skip to content

Commit

Permalink
Removing code from previous PR #2 (#7654)
Browse files Browse the repository at this point in the history
  • Loading branch information
rkreyhsig committed Nov 15, 2018
1 parent 1f6c97d commit 463b3fa
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 38 deletions.
2 changes: 0 additions & 2 deletions client/app/queue/uiReducer/uiConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,5 @@ export const ACTIONS = {
HIDE_VETERAN_CASE_LIST: 'HIDE_VETERAN_CASE_LIST',
SET_USER_IS_VSO_EMPLOYEE: 'SET_USER_IS_VSO_EMPLOYEE',
SET_ORGANIZATION_IDS: 'SET_ORGANIZATION_IDS',

SET_CAN_EDIT_AOD: 'SET_CAN_EDIT_AOD',
SET_ACTIVE_ORGANIZATION_ID: 'SET_ACTIVE_ORGANIZATION_ID'
};
7 changes: 1 addition & 6 deletions client/app/queue/uiReducer/uiReducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ export const initialState = {
loadedUserId: null,
selectedAssignee: null,
selectedAssigneeSecondary: null,
veteranCaseListIsVisible: false,
canEditAod: false
veteranCaseListIsVisible: false
};

const setMessageState = (state, message, msgType) => update(state, {
Expand Down Expand Up @@ -64,10 +63,6 @@ const workQueueUiReducer = (state: UiState = initialState, action: Object = {})
return update(state, {
selectingJudge: { $set: action.payload.selectingJudge }
});
case ACTIONS.SET_CAN_EDIT_AOD:
return update(state, {
canEditAod: { $set: action.payload.canEditAod }
});
case ACTIONS.HIGHLIGHT_INVALID_FORM_ITEMS:
return update(state, {
highlightFormItems: {
Expand Down
1 change: 0 additions & 1 deletion spec/feature/queue/ama_queue_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
end

before do
allow_any_instance_of(AodTeam).to receive(:user_has_access?).with(attorney_user).and_return(true)
allow_any_instance_of(Fakes::BGSService).to receive(:find_address_by_participant_id).and_return(
address_line_1: "Veteran Address",
city: "Washington",
Expand Down
29 changes: 0 additions & 29 deletions spec/feature/queue/case_details_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -394,35 +394,6 @@
end
end

context "edit aod link appears/disappears as expected" do
let(:appeal) { FactoryBot.create(:appeal) }
let(:user) { FactoryBot.create(:user) }
let(:user2) { FactoryBot.create(:user) }

context "when the current user is a member of the AOD team" do
before do
allow_any_instance_of(AodTeam).to receive(:user_has_access?).with(user).and_return(true)
User.authenticate!(user: user)
visit("/queue/appeals/#{appeal.uuid}")
end

it "should display the edit link" do
expect(page).to have_content("Edit")
end
end

context "when the current user is not a member of the AOD team" do
before do
allow_any_instance_of(AodTeam).to receive(:user_has_access?).with(user2).and_return(false)
User.authenticate!(user: user2)
visit("/queue/appeals/#{appeal.uuid}")
end
it "should not display the edit link" do
expect(page).to_not have_content("Edit")
end
end
end

describe "Marking organization task complete" do
context "when there is no assigner" do
let(:qr) { QualityReview.singleton }
Expand Down

0 comments on commit 463b3fa

Please sign in to comment.