fixing the failed tests

department-of-veterans-affairs · Oct 25, 2024 · 8009c08 · 8009c08
1 parent cd81930
commit 8009c08
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/app/serializers/saved_search_serializer.rb b/app/serializers/saved_search_serializer.rb
@@ -11,8 +11,8 @@ class SavedSearchSerializer
   attribute :user do |object|
     user = object.try(:user)
     {
-      css_id: user.try(:css_id),
-      full_name: user.try(:full_name),
+      cssId: user.try(:css_id),
+      fullName: user.try(:full_name),
       id: user.id
     }
   end

diff --git a/client/test/app/nonComp/__snapshots__/Personnel.test.js.snap b/client/test/app/nonComp/__snapshots__/Personnel.test.js.snap
@@ -15,7 +15,7 @@ exports[`Personnel component renders correctly renders correctly 1`] = `
           </h1>
           <a
             class="usa-button-secondary"
-            href="/vha/report/searches"
+            href="/vha/searches"
             type="button"
           >
             View saved searches

diff --git a/client/test/app/nonComp/pages/__snapshots__/ReportPage.test.js.snap b/client/test/app/nonComp/pages/__snapshots__/ReportPage.test.js.snap
@@ -15,7 +15,7 @@ exports[`ReportPage renders correctly renders correctly 1`] = `
           </h1>
           <a
             class="usa-button-secondary"
-            href="/undefined/report/searches"
+            href="/undefined/searches"
             type="button"
           >
             View saved searches

diff --git a/spec/feature/non_comp/saved_searches_spec.rb b/spec/feature/non_comp/saved_searches_spec.rb
@@ -3,7 +3,7 @@
 feature "Saved Searches", :postgres do
   let(:non_comp_org) { VhaBusinessLine.singleton }
   let(:user) { create(:default_user, css_id: "REPORT USER", full_name: "Report User") }
-  let(:vha_saved_searches_url) { "/decision_reviews/vha/report/searches" }
+  let(:vha_saved_searches_url) { "/decision_reviews/vha/searches" }
 
   before do
     User.stub = user

diff --git a/spec/models/serializers/saved_search_serializer_spec.rb b/spec/models/serializers/saved_search_serializer_spec.rb
@@ -21,9 +21,11 @@
         description: "my first search",
         savedSearch: "{report_type: 'event_type_action'}",
         createdAt: saved_search.created_at,
-        userCssId: user.css_id,
-        userFullName: user.full_name,
-        userId: user.id
+        user: {
+          cssId: user.css_id,
+          fullName: user.full_name,
+          id: user.id
+        }
       }
       expect(subject.serializable_hash[:data][:attributes]).to eq(serializable_hash)
     end