Remove package info banner for regular mail user (#21323)

department-of-veterans-affairs · Apr 3, 2024 · b80da33 · b80da33
1 parent c2ac1d5
commit b80da33
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 15 deletions.
diff --git a/client/app/queue/correspondence/review_package/CorrespondenceReviewPackage.jsx b/client/app/queue/correspondence/review_package/CorrespondenceReviewPackage.jsx
@@ -38,6 +38,7 @@ export const CorrespondenceReviewPackage = (props) => {
   const [errorMessage, setErrorMessage] = useState('');
   const [selectedId, setSelectedId] = useState(0);
   const [isReadOnly, setIsReadOnly] = useState(false);
+  const [isInboundOpsTeam, setIsInboundOpsTeam] = useState(false);
   const [reviewPackageDetails, setReviewPackageDetails] = useState({
     veteranName: '',
     taksId: [],
@@ -53,17 +54,19 @@ export const CorrespondenceReviewPackage = (props) => {
     // When a remove package task is active and pending review, the page is read-only
     const isPageReadOnly = (tasks) => {
       const assignedRemoveTask = tasks.find((task) => task.status === 'assigned' && task.type === 'RemovePackageTask');
-      const isInboundOpsTeam = correspondence.organizations.find((org) => org.name === 'Inbound Ops Team');
+      const inboundOpsTeam = correspondence.organizations.find((org) => org.name === 'Inbound Ops Team');
 
-      if(assignedRemoveTask) {
+      setIsInboundOpsTeam(Boolean(inboundOpsTeam));
+
+      if (assignedRemoveTask) {
         setReviewPackageDetails((prev) => {
-          return {...prev, taskId: assignedRemoveTask.id}
-          }
-        )
+          return { ...prev, taskId: assignedRemoveTask.id };
+        }
+        );
       }
 
       // Return true if a removePackageTask that is currently assigned is found, else false
-      return (typeof assignedRemoveTask !== 'undefined') && isInboundOpsTeam;
+      return (typeof assignedRemoveTask !== 'undefined');
     };
 
     try {
@@ -87,9 +90,9 @@ export const CorrespondenceReviewPackage = (props) => {
       });
 
       setReviewPackageDetails((prev) => {
-        return { ...prev, veteranName: `${data.veteran_name.first_name} ${data.veteran_name.last_name}`}
-        }
-      )
+        return { ...prev, veteranName: `${data.veteran_name.first_name} ${data.veteran_name.last_name}` };
+      }
+      );
 
       setEditableData({
         notes: data.notes,
@@ -193,6 +196,7 @@ export const CorrespondenceReviewPackage = (props) => {
             correspondence={props.correspondence}
             packageActionModal={packageActionModal}
             isReadOnly={isReadOnly}
+            isInboundOpsTeam={isInboundOpsTeam}
           />
           <ReviewPackageData
             correspondence={props.correspondence}

diff --git a/client/app/queue/correspondence/review_package/ReviewPackageCaseTitle.jsx b/client/app/queue/correspondence/review_package/ReviewPackageCaseTitle.jsx
@@ -57,8 +57,13 @@ const ReviewPackageCaseTitle = (props) => {
 
   return (
     <div>
-      <CaseTitleScaffolding reviewDetails={props.reviewDetails} correspondence_id = {props.correspondence.id} isReadOnly={props.isReadOnly} />
-      <CaseSubTitleScaffolding {...props} isReadOnly={props.isReadOnly} />
+      <CaseTitleScaffolding
+        reviewDetails={props.reviewDetails}
+        correspondence_id={props.correspondence.id}
+        isReadOnly={props.isReadOnly}
+        isInboundOpsTeam={props.isInboundOpsTeam}
+      />
+      <CaseSubTitleScaffolding {...props} isReadOnly={props.isReadOnly} isInboundOpsTeam={props.isInboundOpsTeam} />
     </div>
   );
 };
@@ -79,7 +84,7 @@ const CaseTitleScaffolding = (props) => {
       <h1 {...headerStyling}>{COPY.CORRESPONDENCE_REVIEW_PACKAGE_TITLE}</h1>
 
       <span {...removebotton}>
-        { props.isReadOnly &&
+        { props.isReadOnly && props.isInboundOpsTeam &&
           <Button
             name="Review removal request"
             styling={{ style: { marginRight: '2rem', padding: '15px', fontSize: 'larger' } }}
@@ -133,18 +138,22 @@ ReviewPackageCaseTitle.propTypes = {
   reviewDetails: PropTypes.object,
   handlePackageActionModal: PropTypes.func,
   correspondence: PropTypes.object,
-  isReadOnly: PropTypes.bool
+  isReadOnly: PropTypes.bool,
+  isInboundOpsTeam: PropTypes.bool
 };
 
 CaseSubTitleScaffolding.propTypes = {
   handlePackageActionModal: PropTypes.func,
   packageActionModal: PropTypes.string,
-  isReadOnly: PropTypes.bool
+  isReadOnly: PropTypes.bool,
+  isInboundOpsTeam: PropTypes.bool
 };
 
 CaseTitleScaffolding.propTypes = {
   correspondence_id: PropTypes.number,
-  isReadOnly: PropTypes.bool
+  reviewDetails: PropTypes.object,
+  isReadOnly: PropTypes.bool,
+  isInboundOpsTeam: PropTypes.bool
 };
 
 export default ReviewPackageCaseTitle;