Skip to content

Commit

Permalink
APPEALS-53603: Modify logic to always show recipient information if p…
Browse files Browse the repository at this point in the history
…resent (#22414)

* initial commit

* making rspec tests happy

* linting

* adding tests back and refactoring

* small char error

---------

Co-authored-by: nhansen3 <noah.hansen1323@gmail.com>
  • Loading branch information
noahhansen-gov and CygnusOfBalance authored Aug 8, 2024
1 parent 9c983b8 commit bdf4c10
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion client/app/queue/components/NotificationTableColumns.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const recipientInformationColumn = (notifications) => {
tableData: notifications,
valueName: 'Recipient Information',
// eslint-disable-next-line no-negated-condition
valueFunction: (notification) => notification.status !== 'delivered' ? '—' : notification.recipient_information
valueFunction: (notification) => notification.recipient_information ?? '—'
};
};

Expand Down
4 changes: 2 additions & 2 deletions client/test/data/notifications.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ export const notifications = [
notification_type: 'Email and SMS',
event_date: '2022-10-27',
event_type: 'Appeal decision mailed (Non-contested claims)',
recipient_email: 'test@caseflow.com',
recipient_email: null,
recipient_phone_number: '2468012345',
email_notification_status: 'sent',
email_notification_status: 'temporary-failure',
sms_notification_status: 'delivered',
notification_content: 'string'
}
Expand Down

0 comments on commit bdf4c10

Please sign in to comment.