dev-support/APPEALS-24154 fix distribution spec tests (#18922)

* skipped duplicates in distribution_spec_deprecated

* remove skipped test referenced by APPEALS-24154

* added tests to distribution spec and skipped them in distribution deprecated

* final skip for deprecated spec, comments in distribution spec

* comments in by_docket_date spec, added distribution_concern_spec

* deleted distribution_spec_deprecated.rb

* refactoring push priority job spec

* more changes to push priority job spec

* another change to before/after blocks

* update comments

* attempt fix for appeal series issue spec

* modify distribution concern spec

* revert change to appeal series issue spec

* remove distribution concern spec as it isn't working in GHA

* Craig/distribution spec changes (#18905)

* skipped duplicates in distribution_spec_deprecated

* remove skipped test referenced by APPEALS-24154

* added tests to distribution spec and skipped them in distribution deprecated

* final skip for deprecated spec, comments in distribution spec

* comments in by_docket_date spec, added distribution_concern_spec

* deleted distribution_spec_deprecated.rb

* refactoring push priority job spec

* more changes to push priority job spec

* another change to before/after blocks

* update comments

* attempt fix for appeal series issue spec

* modify distribution concern spec

* revert change to appeal series issue spec

* remove distribution concern spec as it isn't working in GHA

* fix bug with legacy efolder sync notification job that was causing errors

* add guard to poll docketed legacy appeals job spec in case seed data exists already

* fix database cleaner bug in ama efolder sync job spec

spec/jobs/ama_notification_efolder_sync_job_spec.rb

@@ -180,7 +180,7 @@ def find_appeal_ids_from_first_document_sync
     end
 
     def clean_up_after_threads
-      DatabaseCleaner.clean_with(:truncation, except: %w[notification_events])
+      DatabaseCleaner.clean_with(:truncation, except: %w[notification_events vftypes issref])
     end
   end
 end

spec/jobs/legacy_notification_efolder_sync_job_spec.rb

@@ -196,7 +196,7 @@ def find_appeal_ids_from_first_document_sync
     end
 
     def clean_up_after_threads
-      DatabaseCleaner.clean_with(:truncation, except: %w[notification_events])
+      DatabaseCleaner.clean_with(:truncation, except: %w[notification_events vftypes issref])
     end
 
     def ensure_notification_events_exist

spec/jobs/poll_docketed_legacy_appeals_job_spec.rb

@@ -6,7 +6,7 @@
 
   describe "polling for docketed appeals" do
     before do
-      Seeds::NotificationEvents.new.seed!
+      Seeds::NotificationEvents.new.seed! unless NotificationEvent.count > 0
     end
 
     let!(:today) { Time.now.utc.iso8601 }