Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki/appeals 21905 #18604

Merged
merged 48 commits into from
May 16, 2023
Merged

Ki/appeals 21905 #18604

merged 48 commits into from
May 16, 2023

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    965156a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Configuration menu
    Copy the full SHA
    a1f9d9e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    d397e27 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Jhoang/appeals 21860 (#18545)

    * rendered checkboxes
    
    * labeling, styling, rspecs
    
    * rspec failure
    
    * rspec failure
    
    * removed id prop off checkbox
    
    * duplicate matcher in rspec after merge
    
    ---------
    
    Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7b8eecd View commit details
    Browse the repository at this point in the history
  2. HunJerBAH/APPEALS-17497 hot fixes (#18538)

    * updated contention mst and pact search on contestable issues
    
    * updated feature toggles and feature toggle checks
    
    * added COB user to list of users who can edit MST/PACT
    
    * added feature flags to respective checkboxes
    
    * added admin permissions to mst/pact workflow
    
    * +1
    
    ---------
    
    Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    60c93a2 View commit details
    Browse the repository at this point in the history
  3. updated payload, rspecs, controller params (#18560)

    Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8ed2854 View commit details
    Browse the repository at this point in the history
  4. redirect AMA appeals directly to Add Decisions page (#18533)

    * Update triggers to not include edited
    
    Editing a PR should not trigger the workflow, especially not until new workflows cancel previous ones that are not longer needed.
    
    * redirect AMA appeals directly to Add Decisions page
    
    * Completed testing spec for redirecitng page when 'decision issue to review' is clicked from the dropdown options
    
    ---------
    
    Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
    Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
    3 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bd73235 View commit details
    Browse the repository at this point in the history
  5. 17513 pre-populate MST/PACT checkboxes if data is present in the mode…

    …l. (#18537)
    
    * Redoing branch because of previous errors.
    
    * Added updates made to featureToggles.js
    
    * Implemented auto population
    
    * Finished RSpec test and validated that it works.
    
    * Fixed bug with AddIssuesModal. Some work done on new RSpec test.
    
    * Added participant_id to build method.
    
    * Added RSpec test with correct mock data.
    
    * Saved work changes
    
    * Fixed RSpec again.
    
    * Updated label on PACT ACT checkbox to accurately reflect the wireframes.
    
    ---------
    
    Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    39f5156 View commit details
    Browse the repository at this point in the history
  6. Revert "17513 pre-populate MST/PACT checkboxes if data is present in …

    …the model. (#18537)" (#18571)
    
    This reverts commit ca4d36e.
    youfoundmanesh authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7c91528 View commit details
    Browse the repository at this point in the history
  7. Justin/appeals 17533 (#18531)

    * testing justification text box additions
    
    * Moving IntakeRadioField and recreating RadioField
    
    * changing radiofield import in the AddIssuesModal
    
    * fixing justification redux, code cleanup, comments
    
    * refactoring to new MST PACT context
    
    * checking for mst pact justification box
    
    * adding both mst and pact justifications
    
    * editing spec to reflect changes
    
    * attempting to add a required field
    sulak-j authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3507079 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bd5896f View commit details
    Browse the repository at this point in the history
  9. Ryan appeals/17513 redo (#18573)

    * Redoing branch because of previous errors.
    
    * Added updates made to featureToggles.js
    
    * Implemented auto population
    
    * Finished RSpec test and validated that it works.
    
    * Fixed bug with AddIssuesModal. Some work done on new RSpec test.
    
    * Added participant_id to build method.
    
    * Added RSpec test with correct mock data.
    
    * Saved work changes
    
    * Fixed RSpec again.
    
    * Updated label on PACT ACT checkbox to accurately reflect the wireframes.
    
    * Resolved merge conflicts. IntakeRadioField.jsx now holds the checkbox instead of RadioField.jsx
    
    ---------
    
    Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e41bdbb View commit details
    Browse the repository at this point in the history
  10. Justin/APPEALS-17533-fix (#18577)

    * Fixing feature
    
    * removing extraneous code
    
    * camelCase
    
    * adding check and fixing linting error
    
    * required text
    sulak-j authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    582ce62 View commit details
    Browse the repository at this point in the history
  11. will/appeals 17529 (#18574)

    * Test: it updates the request issue's mst status
    
    * Feat: RequestIssuesUpdate mst status and reason notes update
    
    * Test: RequestIssuesUpdate updates pact status and pact status update reason notes
    
    * Migration: add pact_edited_request_issue_ids to RequestIssuesUpdate
    
    * Feat: RequestIssuesUpdate updates pact status and pact status update reason notes
    
    * Fix: add mst status update reason notes to mock data
    
    * Fix: remove camel case redundant lines from contestable issue #decision_issue
    
    * Refactor: combine migrations for RequestIssuesUpdate into 1 migration
    
    * Fix: Fixed mismatched propnames
    
    ---------
    
    Co-authored-by: William Medders <medders_william@bah.com>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7565aa5 View commit details
    Browse the repository at this point in the history
  12. Migration updates

    youfoundmanesh authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5f1ea69 View commit details
    Browse the repository at this point in the history
  13. hearing.rb updated. claimant_id method and aod method no check for un…

    …recognized_claimants, providing a fix to the daily docket error.
    JCohen642 authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    297a7b7 View commit details
    Browse the repository at this point in the history
  14. test for 'aod?' created and passing

    JCohen642 authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    accdcf4 View commit details
    Browse the repository at this point in the history
  15. unit test/spec for claimant_id

    JCohen642 authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e210354 View commit details
    Browse the repository at this point in the history
  16. PR spec suggestions applied.

    JCohen642 authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ff9428c View commit details
    Browse the repository at this point in the history
  17. b_reed/APPEALS-15886-caseflow (#18446)

    * updated the gemfile for caseflow-commons gem
    
    * ran make install and commit gemfile.lock
    breedbah authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2edbca2 View commit details
    Browse the repository at this point in the history
  18. Update PULL_REQUEST_TEMPLATE.md

    added Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
    nkutub authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4419a92 View commit details
    Browse the repository at this point in the history
  19. Update PULL_REQUEST_TEMPLATE.md

    little updates
    nkutub authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c53c34a View commit details
    Browse the repository at this point in the history
  20. Update PULL_REQUEST_TEMPLATE.md

    added protected data change to auditing.
    nkutub authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    79b0ac2 View commit details
    Browse the repository at this point in the history
  21. Update PULL_REQUEST_TEMPLATE.md

    zurbergram authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f4a1dda View commit details
    Browse the repository at this point in the history
  22. Update PULL_REQUEST_TEMPLATE.md

    zurbergram authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2081f5d View commit details
    Browse the repository at this point in the history
  23. Update PULL_REQUEST_TEMPLATE.md

    zurbergram authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0992632 View commit details
    Browse the repository at this point in the history
  24. Update PULL_REQUEST_TEMPLATE.md

    zurbergram authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0c96354 View commit details
    Browse the repository at this point in the history
  25. Add new tdd & code climate section

    cacevesva authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    e26227e View commit details
    Browse the repository at this point in the history
  26. Add issue to text

    cacevesva authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5df5697 View commit details
    Browse the repository at this point in the history
  27. Add new verbiage

    cacevesva authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    94a6fd2 View commit details
    Browse the repository at this point in the history
  28. Updating code climate text

    cacevesva authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    af63511 View commit details
    Browse the repository at this point in the history
  29. Update PULL_REQUEST_TEMPLATE.md

    zurbergram authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    db13070 View commit details
    Browse the repository at this point in the history
  30. Dev support/vha team management rspec fixes (#18529)

    * Updated some of the membership_request_mailer_spec tests to use the new email address for govdeliveryapi.
    
    * Fixed a small syntax error in the initial notification letter task spec.
    
    * Added a variable to store the email address that the test is using.
    
    * Fixed a code climate issue by refactoring some tests.
    
    * re-run tests
    
    ---------
    
    Co-authored-by: = <tyler.broyles@va.gov>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    ae5bd07 View commit details
    Browse the repository at this point in the history
  31. Dev support/appeals 19613 (#18530)

    * Appeal-19614: Adding assigned, in_progress and completed predocketed caseflow VhaCamo
    
    * Appeals-19615: Adding seeds for VHACareGiver and fixing seeds for VHA Camo
    
    * Uncommenting
    
    * fixing typo
    
    * Appeals-19616: Adding seeds data for VHA Programs
    
    * Appeals-19613: sub tasks
    
    * Uncommit the required change
    
    * Linter changes
    
    * Linting seeds fixes
    
    * Appeals-19614: Reverting the issue the caused by linter
    
    * Linter
    
    * File change due to order of operation
    
    * revision to the code diff
    
    * uninitialized constant was renamed
    
    * renamed method
    
    * Higher level review changes fix
    
    * spec failure fixes
    
    * Fixing the not working case detail
    
    * Changing the position of the method from users to vha due to order of execution
    
    * Code climate fix
    
    ---------
    
    Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
    2 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bbc2b6c View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    e14c52b View commit details
    Browse the repository at this point in the history
  33. APPEALS-15450 updated rspec

    j-n-t-l authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fc441d3 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7992105 View commit details
    Browse the repository at this point in the history
  35. APPEALS-15450 updated rspec

    j-n-t-l authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    26eaa80 View commit details
    Browse the repository at this point in the history
  36. Tracking PR for APPEALS-17680 (#18554)

    * akonhilas/APPEALS-20080 (#18448)
    
    * APPEALS-20080: Added new post route to idt namespace v1
    
    * APPEALS-20080: added validate method to appeals_controller
    
    * APPEALS-20080: transforming keys in hash to snake case
    
    * APPEALS-20080: went back to accepting snake case from IDT, added custom error handling
    
    * APPEALS-20080: updating rspecs
    
    * APPEALS-20080: Made updates from peer review
    
    * APPEALS-20080: Fixed rspec
    
    * Hotfix/APPEALS-21350 (#18497)
    
    * APPEALS-21350: Addressed all of the changes in the description of 21350 except automated testing
    
    * APPEALS-21350: updated error catching for codes, trying to figure out how to get the rest to bubble up
    
    * APPEALS-21350: updated with concise code to handle 401 403 429 status and response format
    
    * APPEALS-21350: updated rspecs, couldn't get exact match on address, used county name
    
    * APPEALS-21350: changed address_POU to address_pou
    
    * APPEALS-21350: created two new private methods, fixed linting error in address model
    
    * APPEALS-21350: removed lighthouse custom error, added 500 status error handling, removed self.error, added full response to fakes
    
    * APPEALS:21350: updated rspec, removed byebug
    
    * APPEALS-21350: added safety navigation to log_error method and fixed typo
    
    * APPEALS-21350: updated error messages to be more broad
    
    * APPEALS-21350: fixed rspec for hearings controller
    
    * APPEALS-21350: fixed build hearsched spec
    
    * APPEALS-21350: added safety navigation to address formatting (#18510)
    
    * Adjust URL
    
    ---------
    
    Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
    Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
    3 people authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    80b0d4d View commit details
    Browse the repository at this point in the history
  37. APPEALS-20824

    laurenberrybah authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d1b9ebd View commit details
    Browse the repository at this point in the history
  38. Added comments

    laurenberrybah authored and KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    82549a9 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    aea479e View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    a5ce70c View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    1f83707 View commit details
    Browse the repository at this point in the history
  42. Updated Naming for Props

    KiMauVA committed May 12, 2023
    Configuration menu
    Copy the full SHA
    dbb9a62 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    470531d View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Configuration menu
    Copy the full SHA
    d4c2613 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d53314 View commit details
    Browse the repository at this point in the history