Justin/APPEALS-23364 #18688
Merged
Justin/APPEALS-23364 #18688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunJerBAH
approved these changes
Jun 4, 2023
jtsangVA
added a commit
that referenced
this pull request
Aug 9, 2023
* will/appeals 17529 (#18574)
* Test: it updates the request issue's mst status
* Feat: RequestIssuesUpdate mst status and reason notes update
* Test: RequestIssuesUpdate updates pact status and pact status update reason notes
* Migration: add pact_edited_request_issue_ids to RequestIssuesUpdate
* Feat: RequestIssuesUpdate updates pact status and pact status update reason notes
* Fix: add mst status update reason notes to mock data
* Fix: remove camel case redundant lines from contestable issue #decision_issue
* Refactor: combine migrations for RequestIssuesUpdate into 1 migration
* Fix: Fixed mismatched propnames
---------
Co-authored-by: William Medders <medders_william@bah.com>
* Migration updates
* APPEALS-21842 Added mst and pact methods to legacy appeals model (#18580)
* APPEALS-17536 - Hotfix for prop naming (#18581)
* Feature/appeals 17521/legacy edit issues (#18585)
* APPEALS-17521: Inital Commits
* updates on edit issue page for legacy appeals
* remove/update comments in issues.js
* clean lint and remove console.log
* appeals controller #edit update
* APPEALS-17521: Code cleanup
* pr feedback
* added error handling for nil HearingDay values
* ensuring judges&attorneys can access edit issues
* attorney update
* Revert "added error handling for nil HearingDay values"
This reverts commit 00a33d4d42dd75f8fbe2c4a888844e9617baae53.
* Revert "Revert "added error handling for nil HearingDay values""
This reverts commit e8bea7adc3a3e175099cf652778fd20eae6f9908.
* Revert "attorney update"
This reverts commit e883f7a3e567b51ba95052879b5bbd183e3b324e.
* some more cleanup
* added comment to clarify reason for removal
---------
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Will/appeals 17561 (#18583)
* Feat: add #update_request_issues_for_mst_and_pact to CaseReviewsController#complete
* Add conditional for legacy appeals
* Test: CaseReviewsController#complete updates the Request Issues for mst and pact
---------
Co-authored-by: William Medders <medders_william@bah.com>
* fixed sentry bug for mst_available in contestable issue model (#18605)
* Ki/appeals 21905 (#18604)
* APPEALS-17536 - Special Issues designation updated
* APPEALS-21905 - Separate MSTPACT textfields
* Jhoang/appeals 21860 (#18545)
* rendered checkboxes
* labeling, styling, rspecs
* rspec failure
* rspec failure
* removed id prop off checkbox
* duplicate matcher in rspec after merge
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* HunJerBAH/APPEALS-17497 hot fixes (#18538)
* updated contention mst and pact search on contestable issues
* updated feature toggles and feature toggle checks
* added COB user to list of users who can edit MST/PACT
* added feature flags to respective checkboxes
* added admin permissions to mst/pact workflow
* +1
---------
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
* updated payload, rspecs, controller params (#18560)
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* redirect AMA appeals directly to Add Decisions page (#18533)
* Update triggers to not include edited
Editing a PR should not trigger the workflow, especially not until new workflows cancel previous ones that are not longer needed.
* redirect AMA appeals directly to Add Decisions page
* Completed testing spec for redirecitng page when 'decision issue to review' is clicked from the dropdown options
---------
Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
* 17513 pre-populate MST/PACT checkboxes if data is present in the model. (#18537)
* Redoing branch because of previous errors.
* Added updates made to featureToggles.js
* Implemented auto population
* Finished RSpec test and validated that it works.
* Fixed bug with AddIssuesModal. Some work done on new RSpec test.
* Added participant_id to build method.
* Added RSpec test with correct mock data.
* Saved work changes
* Fixed RSpec again.
* Updated label on PACT ACT checkbox to accurately reflect the wireframes.
---------
Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
* Revert "17513 pre-populate MST/PACT checkboxes if data is present in the model. (#18537)" (#18571)
This reverts commit ca4d36edc188332aa5ca2b6dd0740d21770b7053.
* Justin/appeals 17533 (#18531)
* testing justification text box additions
* Moving IntakeRadioField and recreating RadioField
* changing radiofield import in the AddIssuesModal
* fixing justification redux, code cleanup, comments
* refactoring to new MST PACT context
* checking for mst pact justification box
* adding both mst and pact justifications
* editing spec to reflect changes
* attempting to add a required field
* APPEALS-21906: MST & PACT reasons migration (#18572)
* Ryan appeals/17513 redo (#18573)
* Redoing branch because of previous errors.
* Added updates made to featureToggles.js
* Implemented auto population
* Finished RSpec test and validated that it works.
* Fixed bug with AddIssuesModal. Some work done on new RSpec test.
* Added participant_id to build method.
* Added RSpec test with correct mock data.
* Saved work changes
* Fixed RSpec again.
* Updated label on PACT ACT checkbox to accurately reflect the wireframes.
* Resolved merge conflicts. IntakeRadioField.jsx now holds the checkbox instead of RadioField.jsx
---------
Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
* Justin/APPEALS-17533-fix (#18577)
* Fixing feature
* removing extraneous code
* camelCase
* adding check and fixing linting error
* required text
* will/appeals 17529 (#18574)
* Test: it updates the request issue's mst status
* Feat: RequestIssuesUpdate mst status and reason notes update
* Test: RequestIssuesUpdate updates pact status and pact status update reason notes
* Migration: add pact_edited_request_issue_ids to RequestIssuesUpdate
* Feat: RequestIssuesUpdate updates pact status and pact status update reason notes
* Fix: add mst status update reason notes to mock data
* Fix: remove camel case redundant lines from contestable issue #decision_issue
* Refactor: combine migrations for RequestIssuesUpdate into 1 migration
* Fix: Fixed mismatched propnames
---------
Co-authored-by: William Medders <medders_william@bah.com>
* Migration updates
* hearing.rb updated. claimant_id method and aod method no check for unrecognized_claimants, providing a fix to the daily docket error.
* test for 'aod?' created and passing
* unit test/spec for claimant_id
* PR spec suggestions applied.
* b_reed/APPEALS-15886-caseflow (#18446)
* updated the gemfile for caseflow-commons gem
* ran make install and commit gemfile.lock
* Update PULL_REQUEST_TEMPLATE.md
added Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
* Update PULL_REQUEST_TEMPLATE.md
little updates
* Update PULL_REQUEST_TEMPLATE.md
added protected data change to auditing.
* Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md
* Add new tdd & code climate section
* Add issue to text
* Add new verbiage
* Updating code climate text
* Update PULL_REQUEST_TEMPLATE.md
* Dev support/vha team management rspec fixes (#18529)
* Updated some of the membership_request_mailer_spec tests to use the new email address for govdeliveryapi.
* Fixed a small syntax error in the initial notification letter task spec.
* Added a variable to store the email address that the test is using.
* Fixed a code climate issue by refactoring some tests.
* re-run tests
---------
Co-authored-by: = <tyler.broyles@va.gov>
* Dev support/appeals 19613 (#18530)
* Appeal-19614: Adding assigned, in_progress and completed predocketed caseflow VhaCamo
* Appeals-19615: Adding seeds for VHACareGiver and fixing seeds for VHA Camo
* Uncommenting
* fixing typo
* Appeals-19616: Adding seeds data for VHA Programs
* Appeals-19613: sub tasks
* Uncommit the required change
* Linter changes
* Linting seeds fixes
* Appeals-19614: Reverting the issue the caused by linter
* Linter
* File change due to order of operation
* revision to the code diff
* uninitialized constant was renamed
* renamed method
* Higher level review changes fix
* spec failure fixes
* Fixing the not working case detail
* Changing the position of the method from users to vha due to order of execution
* Code climate fix
---------
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
* APPEALS-15450 changed timezone method to use users_regional_office
* APPEALS-15450 updated rspec
* APPEALS-15450 added if statement for vso users timezone
* APPEALS-15450 updated rspec
* Tracking PR for APPEALS-17680 (#18554)
* akonhilas/APPEALS-20080 (#18448)
* APPEALS-20080: Added new post route to idt namespace v1
* APPEALS-20080: added validate method to appeals_controller
* APPEALS-20080: transforming keys in hash to snake case
* APPEALS-20080: went back to accepting snake case from IDT, added custom error handling
* APPEALS-20080: updating rspecs
* APPEALS-20080: Made updates from peer review
* APPEALS-20080: Fixed rspec
* Hotfix/APPEALS-21350 (#18497)
* APPEALS-21350: Addressed all of the changes in the description of 21350 except automated testing
* APPEALS-21350: updated error catching for codes, trying to figure out how to get the rest to bubble up
* APPEALS-21350: updated with concise code to handle 401 403 429 status and response format
* APPEALS-21350: updated rspecs, couldn't get exact match on address, used county name
* APPEALS-21350: changed address_POU to address_pou
* APPEALS-21350: created two new private methods, fixed linting error in address model
* APPEALS-21350: removed lighthouse custom error, added 500 status error handling, removed self.error, added full response to fakes
* APPEALS:21350: updated rspec, removed byebug
* APPEALS-21350: added safety navigation to log_error method and fixed typo
* APPEALS-21350: updated error messages to be more broad
* APPEALS-21350: fixed rspec for hearings controller
* APPEALS-21350: fixed build hearsched spec
* APPEALS-21350: added safety navigation to address formatting (#18510)
* Adjust URL
---------
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* APPEALS-20824
* Added comments
* Added spaces around math operators per code climate complaints
* APPEALS-21842 Added mst and pact methods to legacy appeals model (#18580)
* APPEALS-17536 - Hotfix for prop naming (#18581)
* Updated Naming for Props
* APPEALS-21905 - Current State updates WIP
* APPEALS-21905 - Working edit modal save
---------
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: youfoundmanesh <maneshreddy.kommidi@va.gov>
Co-authored-by: IsaiahBar <107133331+IsaiahBar@users.noreply.github.com>
Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
Co-authored-by: Rnmarshall93 <110805785+Rnmarshall93@users.noreply.github.com>
Co-authored-by: Ryan Marshall <Ryan.Marshall@lefant.org>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com>
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: = <tyler.broyles@va.gov>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: j-n-t-l <611441@bah.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: Lauren Berry <95879805+lberrytake2@users.noreply.github.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
* Added MST and PACT reason for change label + data passing) (Re-do) (#18598)
* Added MST and PACT reason for change label + data passing)
* Removed missing binding.pry
* removed binding pry
* removed edit reason and minor refactors
* Added RSpec test for 17539
* updates tests to use new parameters mst_reason and pact_reason. Removed old edit_reason parameter.
* Removed stray binding.pry
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Justin/APPEALS-22806 (#18618)
* fixed pre checked boxes not updating MST/PACT status in intake
* removing extraneous code from radiofield
* fixing the required text to submit
* added safety operator to mst and pact methods.
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* APPEALS-17535: Docket MST & PACT (#18619)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* added try block to contestable issue model cycling request issues (#18621)
* Fix: added mst and pact Justification to AppealsController#update params (#18622)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Justin/APPEALS-22161 (#18610)
* added mst and pact to AMA Issue List for ama appeals.
* added legacy mst and pact GUI status for issues
* fixing line length linting issue
* added legacy mst/pact status rendering on the case details page
* added MST and PACT visual on add decisions page for legacy appeals
* working on spec
* working on spec
* changed to mst_appeal and pact_appeal
* working on rspec
* rspec fixes and AmaIssueList spacing fix
* changing AmaIssueList spacing again
* code cleanup
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* JHoang/APPEALS-17552 (#18620)
* initial commit
* conditional logic to create issue update task
* update on create IssueUpdateTask after establishing appeal
* rubocop disable
* initial_Tasks_factory spec for issueupdatetask
* moved logic for creating task and updated request issue params to create reason for edit note
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* added intake permissions to COB users in test data. (#18652)
* fix checkbox not prepopulating on mst/pact issue legacy decision (#18649)
* fixed checkbox not prepopulating on mst/pact issue legacy decision
* remove console.log
* fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Justin/APPEALS-23333 (#18655)
* removing duplicate code chunk found
* removing renderMstAndPact value (replaced)
* replacing with renderMst and renderPact
* removing deprecated mstPactIdentification
* separating mst and pact renders
* Ricky/appeals 17558 (#18653)
* added mst and pact to AMA Issue List for ama appeals.
* added legacy mst and pact GUI status for issues
* Added mst and pact status to appeal serializer
* fixing line length linting issue
* added legacy mst/pact status rendering on the case details page
* added MST and PACT visual on add decisions page for legacy appeals
* Added prepfilled mst/pact status from store on modal
* Fixed variable to proper name
* added action
* working on spec
* working on spec
* changed to mst_appeal and pact_appeal
* working on rspec
* rspec fixes and AmaIssueList spacing fix
* changing AmaIssueList spacing again
* code cleanup
* Updated special issues for checkbox on save and delete
* Minor formatting and comments
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH/Legacy and AMA Edit Page Bug Fix (#18658)
* updated edit page/modal MST/PACT prefill checkboxes and legacy status not showing
* cleaned up console logs and lint issues
* updated legacy MST/PACT naming convention to match ama issues
* Legacy MST/PACT Justification Text Field in Add Decisions Workflow (#18650)
* test removing SQL code that caused issues
* Add justification text box and show text box toggles
* 'Readded ISSPACt and ISSMST to SQL query'
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Ki/APPEALS-18872 - Create MST & PACT Conditional Rendering within BadgeArea (AC 2.3) - Take 2, Electric Boogaloo (#18672)
* APPEALS-18872 - badgeArea Updates
* APPEALS-18872 - Review Remand Decisions updates
* mst/pact badges to schedule hearings and hearing details
* APPEALS-18872 - Schedule Veteran changes
* fixed mst/pact badge alignment for schedule hearings
* fixed spacing between mst/pact badges in hearing details
* APPEALS-18872 - Fixed CSS
* added intake permissions to COB users in test data. (#18652)
* fix checkbox not prepopulating on mst/pact issue legacy decision (#18649)
* fixed checkbox not prepopulating on mst/pact issue legacy decision
* remove console.log
* fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Justin/APPEALS-23333 (#18655)
* removing duplicate code chunk found
* removing renderMstAndPact value (replaced)
* replacing with renderMst and renderPact
* removing deprecated mstPactIdentification
* separating mst and pact renders
* Ricky/appeals 17558 (#18653)
* added mst and pact to AMA Issue List for ama appeals.
* added legacy mst and pact GUI status for issues
* Added mst and pact status to appeal serializer
* fixing line length linting issue
* added legacy mst/pact status rendering on the case details page
* added MST and PACT visual on add decisions page for legacy appeals
* Added prepfilled mst/pact status from store on modal
* Fixed variable to proper name
* added action
* working on spec
* working on spec
* changed to mst_appeal and pact_appeal
* working on rspec
* rspec fixes and AmaIssueList spacing fix
* changing AmaIssueList spacing again
* code cleanup
* Updated special issues for checkbox on save and delete
* Minor formatting and comments
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH/Legacy and AMA Edit Page Bug Fix (#18658)
* updated edit page/modal MST/PACT prefill checkboxes and legacy status not showing
* cleaned up console logs and lint issues
* updated legacy MST/PACT naming convention to match ama issues
* Legacy MST/PACT Justification Text Field in Add Decisions Workflow (#18650)
* test removing SQL code that caused issues
* Add justification text box and show text box toggles
* 'Readded ISSPACt and ISSMST to SQL query'
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Feature/appeals 17497 master update (#18667)
* edited query to return collection in order from newest to oldest.
* Query Updated to exclude notifications older that 4 days old of the time the query runs.
* tests updated, passing
* PR corrections made to query
* PR corrections made to query. Implemented Arel instead of base SQL query string.
* fixed failing spec, All PR changes applied.
* janet/APPEALS-20062 Create Webhook API (#18468)
* APPEALS-20062 added controller and route
* APPEALS-20062 updated controller + added rspec test
* APPEALS-20062 did a migration and updated logic and rspec
* APPEALS-20062 added in notification events to rspec
* APPEALS-20062 updated controller and rspec
* APPEALS-20062 updated error logging
* APPEALS-20062 updated rspec
* APPEALS-20062 added comments
* APPEALS-20062 typo fix
* APPEALS-20062 split up method into smaller ones
* APPEALS-20062 created log_error method
* APPEALS-20062 moved some methods to private
* APPEALS-20062 added success json message
* APPEALS-20062 code review changes
* APPEALS-20062 added required params
* APPEALS-20062 changed to deep_dup
* APPEALS-20062 undid required params
* APPEALS-20062 added a space
* APPEALS-20062 added required_params
* APPEALS-20062 alignment issue
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* APPEALS-15446: bug fixing in disposition and other fields
* Correcting file path
* removed blank line, merged decision review spec into disposition spec
* removed feature toggle from before and after since its not really needed in this context
* type to notification_type (#18546)
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Updated env for Claim Evidence base URL
* fix spec errors
* Update task timer to correct value to pass specs
* fix duplicate judge assign task test
* fix cavc_dashboard.scss lint error
* fix cavc dashboard feature spec
* lighthouse api update (#18568) (#18570)
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
* fix two login_spec.rb tests
* change expected error in va_dot_gov_service_spec to match recent API updates
* lauren/APPEALS-20823
* Fixed spelling mistake
* test fix for appeal notifications page spec
* Raymond/APPEALS-22849 Updating readme to include setup instructions for Windows and Mac. These instructions are pulled from our sharepoint and are the latest dev setup we have available.
* Raymond/APPEALS-22849 Pulling each type of dev machine setup into a spearate file. This will allow the README to be smaller and easier to parse while devs use the document to setup their machines.
* Raymond/APPEALS-22849 Updating the readme to include a link to the new MD pages in the dev setup to reduce need to scroll up for link
* Raymond/APPEALS-22849 Needs full path with extension to allow github to properly navigate between pages
* Raymond/APPEALS-22849 Update readme to separate the links between windows and mac. Clean up dev setup section to remove redundant information that appears before the docs state otherwise.
* Fixed comment
* akonhilas/APPEALS-13396 (#18539)
* APPEALS-13396: added to copy and updated format instructions
* APPEALS-13396: used regex for uppercase and added newline
* APPEALS-13396: updated with conditionals and dried up code
* APPEALS-13396: added jest tests
* APPEALS-13396: updated syntax for partially granted disposition after peer review
* APPEALS-13396: updated jest tests, added fix for form UI running through rspecs
* APPEALS-13396: updated format mtv judge instructions in queue helpers to reflect react changes
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: snapshot update
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: removed byebugs, updated mtv text, updated jest test
* Test tweak
---------
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Fix failing tests in send_notification_job_spec.rb
This file still needs further cleaning, but the changes in this commit will fix the most pressing issues.
* update snapshots and references to role='cell'
* revert change to DocketSwitchRulingForm.test.js
* b_reed/APPEALS-13386 (#18637)
* APPEALS-13386 added new feature toggle in index
* APPEALS-13396: added to copy and updated format instructions
* APPEALS-13396: used regex for uppercase and added newline
* APPEALS-13396: updated with conditionals and dried up code
* APPEALS-13396: added jest tests
* APPEALS-13396: updated syntax for partially granted disposition after peer review
* APPEALS-13396: updated jest tests, added fix for form UI running through rspecs
* motion to vacate feature toggle
* merge conflict resolution
* Jest tests for feature toggle
* byebug removal
* toggle logic reversal
* Fix the GH code suggestion whitespace oddities
* added feature toggle to enable_features_dev
* reformatted code
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* skipping test in hearing days nav
* Add make commands to reduce CPU usage of application when running (#18639)
* add cold make commands and ignore hot-update files
* Update Makefile.example
* Test fixes
* Fix CC issue
---------
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Janet Lu <93942793+j-n-t-l@users.noreply.github.com>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Maite Piedra Yera <maite.piedrayera@va.gov>
Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Craig Reese <Reese_Craig@bah.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: Lauren Berry <95879805+lberrytake2@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: Jeremy Shields <jeremy.shields@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
* reverted removed changes from master
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Janet Lu <93942793+j-n-t-l@users.noreply.github.com>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Maite Piedra Yera <maite.piedrayera@va.gov>
Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Craig Reese <Reese_Craig@bah.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: Lauren Berry <95879805+lberrytake2@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: Jeremy Shields <jeremy.shields@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
* APPEALS-23363: Case Timeline Entry Details: Editing Designation for AMA appeals during Decision Workflow (#18676)
* Added create_issue_update_task for AMA appeals add decision workflow
* Removed console logs, binding pry, and unnecessary comments
* Edited issueupdatetask to display proper users
* Fixed rendering or assignedTp
* Revmoed console log
* refactored to handle HLR/SSC cases
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Ryan appeals 23327 (#18684)
* Fix: added mst and pact Justification to AppealsController#update params
* Feat: create IssuesUpdateTask in AppealsController#uodate
* Test: AppealsController POST request to #update
Responds with 200 and creates IssueUpdateTasks for each MST/PACT edited issue.
* updated mst edit data and pact edit data in request issues update model
* created issueUpate task creation logic for mst/pact edits
* added completed by to edit task creation
* updated issue update task to accept a header type instead of hard coded to "Edited Issue:"
* initial commit (finished work)
---------
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH APPEALS-23300: IssueUpdate Task Created when MST/PACT Edited (#18674)
* Fix: added mst and pact Justification to AppealsController#update params
* Feat: create IssuesUpdateTask in AppealsController#uodate
* Test: AppealsController POST request to #update
Responds with 200 and creates IssueUpdateTasks for each MST/PACT edited issue.
* updated mst edit data and pact edit data in request issues update model
* created issueUpate task creation logic for mst/pact edits
* added completed by to edit task creation
* updated issue update task to accept a header type instead of hard coded to "Edited Issue:"
* updated task instruction method to match new syntax
* added in commented out code for testing
* cleaned up branch and added filtering for Edited Issue vs Removed Issues
---------
Co-authored-by: William Medders <medders_william@bah.com>
* Appeals 23336 - BUGFIX - Update back button routing for AMA in Add Decisions workflow (#18677)
* Removed JUDGE_AMA_CHECKOUT_SP_ISSUE; updated rspec
* Removed backwards routing to special issues page
---------
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Justin/APPEALS-23364 (#18688)
* addidng task creation for legacy issue
* Added exception for legacy appeals completed by
* removing unless for legacy cases
---------
Co-authored-by: Kevin Ma <magavakevin10@gmail.com>
* Ki/APPEALS-23390 - Modify IDT API to reflect MST/PACT Act appeals (#18689)
* APPEALS-18872 - badgeArea Updates
* APPEALS-18872 - Review Remand Decisions updates
* mst/pact badges to schedule hearings and hearing details
* APPEALS-18872 - Schedule Veteran changes
* fixed mst/pact badge alignment for schedule hearings
* fixed spacing between mst/pact badges in hearing details
* APPEALS-18872 - Fixed CSS
* added intake permissions to COB users in test data. (#18652)
* fix checkbox not prepopulating on mst/pact issue legacy decision (#18649)
* fixed checkbox not prepopulating on mst/pact issue legacy decision
* remove console.log
* fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Justin/APPEALS-23333 (#18655)
* removing duplicate code chunk found
* removing renderMstAndPact value (replaced)
* replacing with renderMst and renderPact
* removing deprecated mstPactIdentification
* separating mst and pact renders
* Ricky/appeals 17558 (#18653)
* added mst and pact to AMA Issue List for ama appeals.
* added legacy mst and pact GUI status for issues
* Added mst and pact status to appeal serializer
* fixing line length linting issue
* added legacy mst/pact status rendering on the case details page
* added MST and PACT visual on add decisions page for legacy appeals
* Added prepfilled mst/pact status from store on modal
* Fixed variable to proper name
* added action
* working on spec
* working on spec
* changed to mst_appeal and pact_appeal
* working on rspec
* rspec fixes and AmaIssueList spacing fix
* changing AmaIssueList spacing again
* code cleanup
* Updated special issues for checkbox on save and delete
* Minor formatting and comments
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH/Legacy and AMA Edit Page Bug Fix (#18658)
* updated edit page/modal MST/PACT prefill checkboxes and legacy status not showing
* cleaned up console logs and lint issues
* updated legacy MST/PACT naming convention to match ama issues
* Legacy MST/PACT Justification Text Field in Add Decisions Workflow (#18650)
* test removing SQL code that caused issues
* Add justification text box and show text box toggles
* 'Readded ISSPACt and ISSMST to SQL query'
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* APPEALS-23390 - idt serializer spec update
* APPEALS-23390 - Add mstpact legacy badge attribute
* APPEALS-23390 - Safety for nil issue
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
* APPEALS-22938 (#18669)
* Added Textfield, updated checkbox constants, and saved justification to state
* Updated justification to state and decision issue
* Updated serializer
* Fixed serializer variables
---------
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Isaiah b/appeals 23322 (#18703)
* Fix: added mst and pact Justification to AppealsController#update params
* Feat: create IssuesUpdateTask in AppealsController#uodate
* Test: AppealsController POST request to #update
Responds with 200 and creates IssueUpdateTasks for each MST/PACT edited issue.
* updated mst edit data and pact edit data in request issues update model
* created issueUpate task creation logic for mst/pact edits
* Added vbms mst and pact columns
* added vbms mst/pact preloading into intake/edit params
* added issue method
* added logic for AC 2 and 3 for VBMS MST/PACT issues
* removed commented code for testing
---------
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Feature: Establishment Task during AMA Intake (#18670)
* Fix: added mst and pact Justification to AppealsController#update params
* Feat: create IssuesUpdateTask in AppealsController#uodate
* Test: AppealsController POST request to #update
Responds with 200 and creates IssueUpdateTasks for each MST/PACT edited issue.
* updated mst edit data and pact edit data in request issues update model
* Feature/appeals 17497 master update (#18667)
* edited query to return collection in order from newest to oldest.
* Query Updated to exclude notifications older that 4 days old of the time the query runs.
* tests updated, passing
* PR corrections made to query
* PR corrections made to query. Implemented Arel instead of base SQL query string.
* fixed failing spec, All PR changes applied.
* janet/APPEALS-20062 Create Webhook API (#18468)
* APPEALS-20062 added controller and route
* APPEALS-20062 updated controller + added rspec test
* APPEALS-20062 did a migration and updated logic and rspec
* APPEALS-20062 added in notification events to rspec
* APPEALS-20062 updated controller and rspec
* APPEALS-20062 updated error logging
* APPEALS-20062 updated rspec
* APPEALS-20062 added comments
* APPEALS-20062 typo fix
* APPEALS-20062 split up method into smaller ones
* APPEALS-20062 created log_error method
* APPEALS-20062 moved some methods to private
* APPEALS-20062 added success json message
* APPEALS-20062 code review changes
* APPEALS-20062 added required params
* APPEALS-20062 changed to deep_dup
* APPEALS-20062 undid required params
* APPEALS-20062 added a space
* APPEALS-20062 added required_params
* APPEALS-20062 alignment issue
---------
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* APPEALS-15446: bug fixing in disposition and other fields
* Correcting file path
* removed blank line, merged decision review spec into disposition spec
* removed feature toggle from before and after since its not really needed in this context
* type to notification_type (#18546)
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Updated env for Claim Evidence base URL
* fix spec errors
* Update task timer to correct value to pass specs
* fix duplicate judge assign task test
* fix cavc_dashboard.scss lint error
* fix cavc dashboard feature spec
* lighthouse api update (#18568) (#18570)
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
* fix two login_spec.rb tests
* change expected error in va_dot_gov_service_spec to match recent API updates
* lauren/APPEALS-20823
* Fixed spelling mistake
* test fix for appeal notifications page spec
* Raymond/APPEALS-22849 Updating readme to include setup instructions for Windows and Mac. These instructions are pulled from our sharepoint and are the latest dev setup we have available.
* Raymond/APPEALS-22849 Pulling each type of dev machine setup into a spearate file. This will allow the README to be smaller and easier to parse while devs use the document to setup their machines.
* Raymond/APPEALS-22849 Updating the readme to include a link to the new MD pages in the dev setup to reduce need to scroll up for link
* Raymond/APPEALS-22849 Needs full path with extension to allow github to properly navigate between pages
* Raymond/APPEALS-22849 Update readme to separate the links between windows and mac. Clean up dev setup section to remove redundant information that appears before the docs state otherwise.
* Fixed comment
* akonhilas/APPEALS-13396 (#18539)
* APPEALS-13396: added to copy and updated format instructions
* APPEALS-13396: used regex for uppercase and added newline
* APPEALS-13396: updated with conditionals and dried up code
* APPEALS-13396: added jest tests
* APPEALS-13396: updated syntax for partially granted disposition after peer review
* APPEALS-13396: updated jest tests, added fix for form UI running through rspecs
* APPEALS-13396: updated format mtv judge instructions in queue helpers to reflect react changes
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: feature testing thru gh actions
* APPEALS-13396: snapshot update
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: jest updates
* APPEALS-13396: removed byebugs, updated mtv text, updated jest test
* Test tweak
---------
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Fix failing tests in send_notification_job_spec.rb
This file still needs further cleaning, but the changes in this commit will fix the most pressing issues.
* update snapshots and references to role='cell'
* revert change to DocketSwitchRulingForm.test.js
* b_reed/APPEALS-13386 (#18637)
* APPEALS-13386 added new feature toggle in index
* APPEALS-13396: added to copy and updated format instructions
* APPEALS-13396: used regex for uppercase and added newline
* APPEALS-13396: updated with conditionals and dried up code
* APPEALS-13396: added jest tests
* APPEALS-13396: updated syntax for partially granted disposition after peer review
* APPEALS-13396: updated jest tests, added fix for form UI running through rspecs
* motion to vacate feature toggle
* merge conflict resolution
* Jest tests for feature toggle
* byebug removal
* toggle logic reversal
* Fix the GH code suggestion whitespace oddities
* added feature toggle to enable_features_dev
* reformatted code
---------
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* skipping test in hearing days nav
* Add make commands to reduce CPU usage of application when running (#18639)
* add cold make commands and ignore hot-update files
* Update Makefile.example
* Test fixes
* Fix CC issue
---------
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Janet Lu <93942793+j-n-t-l@users.noreply.github.com>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Maite Piedra Yera <maite.piedrayera@va.gov>
Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Craig Reese <Reese_Craig@bah.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: Lauren Berry <95879805+lberrytake2@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: Jeremy Shields <jeremy.shields@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
* Ki/APPEALS-18872 - Create MST & PACT Conditional Rendering within BadgeArea (AC 2.3) (#18659)
* APPEALS-18872 - badgeArea Updates
* APPEALS-18872 - Review Remand Decisions updates
* mst/pact badges to schedule hearings and hearing details
* APPEALS-18872 - Schedule Veteran changes
* fixed mst/pact badge alignment for schedule hearings
* fixed spacing between mst/pact badges in hearing details
* APPEALS-18872 - Fixed CSS
* added intake permissions to COB users in test data. (#18652)
* fix checkbox not prepopulating on mst/pact issue legacy decision (#18649)
* fixed checkbox not prepopulating on mst/pact issue legacy decision
* remove console.log
* fix
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* Justin/APPEALS-23333 (#18655)
* removing duplicate code chunk found
* removing renderMstAndPact value (replaced)
* replacing with renderMst and renderPact
* removing deprecated mstPactIdentification
* separating mst and pact renders
* Ricky/appeals 17558 (#18653)
* added mst and pact to AMA Issue List for ama appeals.
* added legacy mst and pact GUI status for issues
* Added mst and pact status to appeal serializer
* fixing line length linting issue
* added legacy mst/pact status rendering on the case details page
* added MST and PACT visual on add decisions page for legacy appeals
* Added prepfilled mst/pact status from store on modal
* Fixed variable to proper name
* added action
* working on spec
* working on spec
* changed to mst_appeal and pact_appeal
* working on rspec
* rspec fixes and AmaIssueList spacing fix
* changing AmaIssueList spacing again
* code cleanup
* Updated special issues for checkbox on save and delete
* Minor formatting and comments
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH/Legacy and AMA Edit Page Bug Fix (#18658)
* updated edit page/modal MST/PACT prefill checkboxes and legacy status not showing
* cleaned up console logs and lint issues
* updated legacy MST/PACT naming convention to match ama issues
* Legacy MST/PACT Justification Text Field in Add Decisions Workflow (#18650)
* test removing SQL code that caused issues
* Add justification text box and show text box toggles
* 'Readded ISSPACt and ISSMST to SQL query'
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
* Establishment Task AC 1
* Removed comments
* created issueUpate task creation logic for mst/pact edits
* Added vbms mst and pact columns
* added vbms mst/pact preloading into intake/edit params
* EstablishmentTask #format_description_text
* Format description text - concat category and description for nonrating issue
* Feature: EstablishmentTask
Condition where a prior decision from VBMS with mst/pact is updated during intake
* Fix merge conflict
* Revert to feature: unwanted changes for this PR
* Refactor: create establishment task before vso tracking tasks
* removed changes not involved with story work
* added skip for non-mst pact issues
* remove schema changes outside of PR
---------
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Janet Lu <93942793+j-n-t-l@users.noreply.github.com>
Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>
Co-authored-by: Maite Piedra Yera <maite.piedrayera@va.gov>
Co-authored-by: Christopher Aceves <christopher.aceves@va.gov>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Craig Reese <Reese_Craig@bah.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: Lauren Berry <95879805+lberrytake2@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Matt Roth <mattcroth@gmail.com>
Co-authored-by: Jeremy Shields <jeremy.shields@va.gov>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: Minhazur Rahaman <minhazur9@gmail.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: Ki Mau <ki.mau@va.gov>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: sulak-j <95875751+sulak-j@users.noreply.github.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: 631068 <rickymanus@hy666rq001.lan>
Co-authored-by: sulak-j <justin.sulak@va.gov>
Co-authored-by: isaiahsaucedo <irsaucedo5@gmail.com>
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: IsaiahBar <isaiah.barnett@va.gov>
* Bug Fix: cycle through array backwards when creating IssuesUpdateTasks (#18693)
* Bug Fix: cycle through array backwards when creating IssuesUpdateTasks
* Add reverse_each to task handlers
---------
Co-authored-by: William Medders <medders_william@bah.com>
* HunJerBAH/APPEALS 23467: Updated MST/PACT Edit AMA Appeal Success Banner (#18699)
* create format for MST/PACT issue banner
* fixed linting issues
* created methods for MST/PACT success banner cases
* created separate banner workflow for MST/PACT edit
* added bullets instead of minuses to success banner
* added legacy error handling
* removed unused variable
* APPEALS-23318 MST/PACT VBMS Ratings Special Issue Designation (#18685)
* APPEALS-23318 added backend logic to handle vbms ratings disability special issues in cf
* update logic to handle mst and pact status checks in UI
* updated bgs fake service for demo data
* APPEALS-23556 - Fix casing for Pact Act (#18705)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* APPEALS-22938 - hotfix (#18720)
* Hotfix to create separate queue checkbox component
* Updated serializer
* updated serializer value for mst and issues update task creation
* reverted changes
* added changes for MST and task creation in case reviews controller
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* Khalin/appeals 23400 (#18712)
* updated edit page/modal MST/PACT prefill checkboxes and legacy status not showing
* cleaned up console logs and lint issues
* updated legacy MST/PACT naming convention to match ama issues
* Adding feature toggle
* Toggle to enable/disable justification
* fix on render issue
* fixing justification reason toggle
* Fixed submit on edit issues modal
* added feature toggle for decisions and edit workflow
---------
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: sulak-j <justin.sulak@va.gov>
* Justin/APPEALS-23365 (#18690)
* addidng task creation for legacy issue
* Added exception for legacy appeals completed by
* removing unless for legacy cases
* initial commit ("Ryan's")
* Added IssueUpdateTasks for EditPage Issues
* moving changes to private methods
* removing binding.pry from leftover testing
* added mst/pact status from current issue params
---------
Co-authored-by: Kevin Ma <magavakevin10@gmail.com>
Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Updates logic for Caseflow to pull contention level special issues from VBMS Core. (#18732)
* APPEALS-23259: Pull contention level special issues from VBMS core
* +1
* Adjust spacing for issueupdatetask + fix linting (#18734)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* fixed no description on issue update task after creation from edit issue page (#18736)
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* VBMS generators using bgs_contention (#18740)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* set sequencing of the field as per wireframe (#18741)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* check if previously mst was true (#18730)
Co-authored-by: Razor Talent <razortalent@Razors-MBP.fios-router.home>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Add Decisions Card Now Displays Special Issues (#18733)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Checkboxes now persist when user clicks cancel (#18758)
* Hid MST/PACT checboxes for HLR and SC (#18757)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Fix: only users with edit privileges (#18761)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* HunJerBAH/APPEALS-7497 Feature Toggle Update (#18737)
* updated banner and legacy correct issues behind toggle
* updated AMA mst/pact decisions update behind feature toggle
* put legacy mst/pact edit in decisions workflow behind toggle
* put legacy mst/pact check behind feature toggle
* put AMA edit task creation behind feature toggles
* put legacy Correct Issues Link behind feature toggle
* put intake task creation behind feature toggle
* put special issues AMA/Legacy behind feature toggles
* put legacy decisions edit behind feature toggles
* put legacy case detail special issues behind feature toggle
* updated decisions workflow behind feature toggles
* updated spec feature toggles
* added mst/pact methods for ratings contentions (#18762)
* created SpecialIssueEditTeam for task assignment (#18763)
* HunJerBAH/APPEALS-23259 (#18769)
* added mst/pact methods for ratings contentions
* updated ratings pact contention method
* rolled back verfy edit issue restriction
* VBMS Core issue fix (#18776)
* fix modal (#18780)
* Fix: flash success message after legacy appeal MST/Pact update. (#18775)
Co-authored-by: William Medders <medders_william@bah.com>
* Ki/APPEALS-23697 - Add MST and PACT Badges to Schedule Veterans Waiting Tabs (#18760)
* APPEALS-23697 - Badge updates for waiting Veterans
* Adjust spacing for issueupdatetask + fix linting (#18734)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* fixed no description on issue update task after creation from edit issue page (#18736)
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* VBMS generators using bgs_contention (#18740)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* set sequencing of the field as per wireframe (#18741)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* check if previously mst was true (#18730)
Co-authored-by: Razor Talent <razortalent@Razors-MBP.fios-router.home>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Add Decisions Card Now Displays Special Issues (#18733)
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* APPEALS-23697 - Linting
* APPEALS-23697 - Jest, Snapshots, Feature Toggles
---------
Co-authored-by: Kevma50287 <104021955+Kevma50287@users.noreply.github.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com>
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com>
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: SanthiParakal133 <132940479+SanthiParakal133@users.noreply.github.com>
Co-authored-by: Razor Talent <razortalent@Razors-MBP.fios-router.home>
Co-authored-by: Dev-KRedd <134650238+Dev-KRedd@users.noreply.github.com>
* Destroy RequestIssuesUpdate instance if @error_code :no_changes (#18779)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* JHoang/APPEALS-23883 (#18755)
* add call to special_issues_controller.rb#create on ama add decisions
* fixed special issues initlal payload empty
* fixed special issue list params
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Added line to refresh legacyappeal issues
* Added check for legacy appeals
* Bugfix: Intake admin can't edit special issues designation (#18794)
* Refactor to prevent short-circuit logic
* Refactor shortcircuit logic
* Fix: allow description to pass to IssuesUpdateTask task instructions in decision flow
* Update backend banner logic (#18807)
* Added missing parentheses for boolean logic
* Removed biding prys
* disabling feature toggle covering justification (#18806)
* Khalin/appeals 24109 (#18816)
* Fixed rendering of decision issue special issues
* Special issues designation now renders
---------
Co-authored-by: Kevin Ma <magavakevin10@gmail.com>
* Fixed banner error on save edit issues (#18829)
* Fix: mail intake can no longer see mst/pact chkbx on intake radio field (#18826)
Co-authored-by: William Medders <medders_william@bah.com>
* get vbms core contentions by participant id and updated bgs gem (#18791)
* updated bgs gem to get contentions by participant id
* added logic to handle core contentions special based on mapping rating contention id
* fixed the logic based on bgs service response
* core contentions special issues pre populate fix
* APPEALS-24294 & APPEALS-24295 vbms ratings issues fix
* Ki/APPEALS-24160 MST/PACT Issues - Hearings Details Worksheet (#18833)
* APPEALS-24160 - Initial Change
* mst/pact to hearing worksheet and printed worksheet
* APPEALS-24160 - Updated text
* mst/pact to printed hearing for legacy?
* fix mst/pact badge for legacy hearing details
* APPEALS-24160 - Legacy update for Remand
* APPEALS-24160 - Updated FeatureToggle TimeSlotCard
---------
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-24294 & APPEALS-24295 vbms ratings special issues spistn typo fix
* updated bgs gem to use ref
* updated gemfile lock
* Handling the format description text
* Nil checking on format_description_text
* Update MST Badage color
* Fix mst pact flash edit message (#18846)
* added logic to handle multiple rating profiles with rating decision special issues and updated bgs service record maker
* Fix: prepopulated from vbms checkboxes (#18849)
Co-authored-by: William Medders <medders_william@bah.com>
* Will/appeals 24373 (#18840)
* WIP refactor CaseReviewsController#update_request_issues_for_mst_and_pact
* Fix: refactor update_request_issues_for_mst_and_pact
---------
Co-authored-by: William Medders <medders_william@bah.com>
* MST Badge color update
* fix for banner
* changed logic to check for mst/pact changes
* Added the updated case.rb and seed_legacy_appeals.rake files.
* updates case.rb for models and generators
* KevMa/APPEALS-24401 - Decision issues incorrect rendering of special issues and not persistence of MST/PACT status (WIP) (#18857)
* APPEALS-24401 Temp possible mst/pact fixes
* APPEALS-24401 - MstPact migration to decision_issues
* APPEALS-24401 - Updated migration naming
* APPEALS-24401 - Working DecisionIssues update
* APPEALS-24401 - Appeal mstpact Designation
* APPEALS-24401 - Decision Issue updates
* APPEALS-24401 Removed additional iteration
* updated local variable
---------
Co-authored-by: Kevin Ma <magavakevin10@gmail.com>
Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
* update verbiage for als rating to identify special issue as pact
* Refactor format_description_text (#18868)
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* APPEALS-24590 added logic to handle an edge case mapping dissn to pull core contentions special issues if the disabilities does not have any special issues
* APPEALS-24590 updated rating issue method logic in rating model
* Will/appeals 24129 benefit type (#18887)
* Added benefit type to decision review issues update task
* Added benefit type to intake edit issues update task
* Added benefit type to legacy decision review issues update task
* revert flash message
* Refactor flash message logic for legacy intake edit
* restored schema from feature branch
---------
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* Will/appeals 24663 (#18890)
* Added benefit type to establishment task
* Capitalize IssuesUpdateTask benefit type for AMA edit
* Change condition to contested_issue_description
---------
Co-authored-by: William Medders <medders_william@bah.com>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
* APPEALS-24590 updated logic to handle rating decision deserialize special issue hash method
* APPEALS-24578 update correct verbiage
* HunJerBAH/APPEALS-23698 (#18748)
* created special_issue_changes table
* created record for established issues
* made edit mst/pact and vbms mst/pact not mandatory
* added special issue change log for AMA edit
* updated establishment special issues record
* added legacy appeal Special Issue record
* added legacy Special Issue change record for decisions
* added special issue change record to case reviews for AMA
* added justification FT to MST/PACT justification field
* updated AMA decisions workflow to match decision tracking changes
* fixed bug with legacy success message on edit page
* added decision issue id to special issue changes table
* moved mst/pact task/reporting creation to issue updater
* added decision review mst/pact overruling issue mst/pact status
* initial commit (#18901)
Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* APPEALS-24590 fix to get rba contention data
* Feature Tests Legacy Queue Workflow (#18904)
* Preliminary Changes to feature test
* APPEALS-22932 Features tests legacy appeal issue edit
* Created all four scenarios
* refactor
* APPEALS-22932 Speci…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-23364
Description
Added task creation for legacy Appeals when editing MST/PACT issues
Acceptance Criteria
Code compiles correctly
The following information is available on the Case Details page in the Case Timeline section for each of the following sections:
IssuesUpdate action header
Date issue was edited
Name of person who made changes to the issue’s special issue designation
Issue for which the special issue designation changed
Original and Current special issue designations
Note: You will need to expand the task instructions to view all the data.
AC 1. When I edit an existing issue on a LEGACY appeal during the add decision workflow and add PACT Act to the previously un-designated issue, when I save my edit, the five bullets are visible in the Case Timeline section.
AC 2. When I edit an existing issue on a LEGACY appeal during the add decision workflow and add MST to the previously un-designated issue, when I save my edit, the five bullets are visible in the Case Timeline section.
AC 3. When I edit an existing issue on a LEGACY appeal during the add decision workflow and remove the PACT Act designation from an issue, when I save my edit, the five bullets are visible in the Case Timeline section.
AC 4. When I edit an existing issue on a LEGACY appeal during the add decision workflow and remove the MST designation from an issue, when I save my edit, the five bullets are visible in the Case Timeline section.
Testing Plan