-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MattT/APPEALS-24643 #18884
Merged
Merged
MattT/APPEALS-24643 #18884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and destination audit tables and functions
…f-veterans-affairs/caseflow into MattT/APPEALS-24643
This reverts commit d38eb98.
Code Climate has analyzed commit 4953e99 and detected 0 issues on this pull request. View more on Code Climate. |
…distros in pacman
ThorntonMatthew
changed the base branch from
master
to
hearings/pacman-triple-j-branch-of-excellence
June 28, 2023 12:37
Base automatically changed from
hearings/pacman-triple-j-branch-of-excellence
to
feature/APPEALS-19983
June 29, 2023 01:50
…of-excellence' into MattT/APPEALS-24643
ThorntonMatthew
changed the base branch from
feature/APPEALS-19983
to
hearings/pacman-triple-j-branch-of-excellence
June 29, 2023 01:58
ThorntonMatthew
changed the base branch from
hearings/pacman-triple-j-branch-of-excellence
to
feature/APPEALS-19983
June 29, 2023 01:59
mchbidwell
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-24643
Description
Adds
uuid
column to thevbms_communication_packages
andvbms_distributions
tables. Updates were made toMailRequestJob
to populate these values from Pacman responses.Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedBest practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling