-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix/APPEALS-9461 V4 #18949
Merged
Merged
hotfix/APPEALS-9461 V4 #18949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 15dd619 and detected 0 issues on this pull request. View more on Code Climate. |
raymond-hughes
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-9461
Description
Content is not properly encoded and causes assistive technology to convey incorrect information.
Acceptance Criteria
1 - (PREVIOUSLY SOLVED) On the Review Cases | Caseflow screen (Caseflow), sort instructions are read by assistive technology when reading the data. For example, “Case Details Sort by Case Details Link Patel Columbus (60003775) This is a paper case Column 2” is read for cell (2,2). This incorrectly conveys that a sort can be executed by activating the cell.
When an active link for a person is read by JAWS it indicates that it is sortable, still. (Screenshot attached)
2 - (SOLVED BY THIS PR) Throughout the product, tables are not read correctly by assistive technology—the first column is read as a blank column. For example, on the Claims Folder | Caseflow Reader screen (Caseflow -> Patel Columbus (60003775) -> View docs), the first column is read as a blank column.
(Screenshot attached.)
3 - (PREVIOUSLY SOLVED) PDFs exported from the product are not tagged. For example, on the Case Details | Caseflow screen (Caseflow -> Patel Columbus (60003775) -> View docs -> VA 21-526 Veterans Application for Compensation or Pension -> download pdf), the exported PDF is not tagged. Tags are required for interoperability with assistive technology.
Reader team input required.
4 - (SOLVED BY THIS PR) On the Draft Decision | Review Remand Reasons screen (Caseflow -> Victor R Rice (30255077) -> Select an action… ( ASSIGNED ON : 05/26/2006DAYS WAITING : 5866 option Ready for Dispatch focused, 2 of 2. 2 results available.) -> Continue (Blue Water) -> Continue), the names for check boxes are not read correctly by assistive technology. For example, when tab is used to move the focus to the Current findings check box, “1-DA” is read for the name.
5 - (PREVIOUSLY SOLVED) On the Scheduled Hearings screen (Switch product -> Caseflow Hearings), when tab is used to move the focus to the first component of a date, the entire date is not read in the order that is displayed. For example, when tab is used to move the focus to the From: field, “From: Date Time Edit 2022-05-17 Month From: edit spin box 05” is read—the year is read first, not last.
Testing Plan for Acceptance Criteria 2
Testing Plan for Acceptance Criteria 4
User Facing Changes
Code Documentation Updates
Storybook Story
For Frontend (Presentationa) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling