APPEALS-24987 #18952
Merged
APPEALS-24987 #18952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4f4ee14 and detected 45 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
AKeyframe
approved these changes
Jul 13, 2023
Aaron-Willis
pushed a commit
that referenced
this pull request
Aug 28, 2023
* APPEALS-24987 Added redis-mutex to gemfile * APPEALS-24987 added RedisMutex init and lock * removed "on" lock in EPE * added comments, retrying lock using "id" * removing lock on "id" * deleting extra line * saving progress * removing debugging lines --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.devops.va.gov/browse/APPEALS-24987
Description
sync!method in EndProductEstablishment into a critical section so that only one method can run at any given time. This is to prevent deadlock scenarios.Acceptance Criteria
sync!on that EPE has to wait until the first sync is finished and the lock released before the next sync method will execute.Testing Plan