APPEALS-23521 CAVC Dashboard not showing all issues for Remand

[jonathanh-va]

Resolves 23521

Description

• Changed CAVC Dashboard to show all issues from source appeal
• Fix CAVC Dashboard not created for some remand types

Acceptance Criteria

• Code compiles correctly

Testing Plan

For 23520

1. Login as CAVC Litigation Admin
2. On the "Your cases" page, click the "Search cases" link to be taken to the "Veteran Case Search" page
3. On the "Veteran Case Search" page, enter a Veteran ID to locate an existing Appeal (4 million series)
4. On the results page, click on the docket number of a case to add a CAVC Remand to
5. Click the "Add CAVC Remand" button
6. Choose one of the following "How are you proceeding" options:
   • Affirmed
   • Dismissal, other than death
   • Settlement
7. Fill out remaining info and click the "Submit" button
8. Login as an OCC and/or OAI team member.
9. On the "Your cases" page, click the "Search cases" link to be taken to the "Veteran Case Search" page
10. Search the veteran ID you used to create a CAVC Remand
11. Go into the source appeal case details page
12. Click on the CAVC Dashboard button
13. Observe that a CAVC Dashboard is created for the new remand you just made.

For 23521

1. Login as CAVC Litigation Admin
2. On the "Your cases" page, click the "Search cases" link to be taken to the "Veteran Case Search" page
3. On the "Veteran Case Search" page, enter a Veteran ID to locate an existing Appeal (4 million series)
4. On the results page, click on the docket number of a case to add a CAVC Remand to
5. Click the "Add CAVC Remand" button
6. Choose one of the following "How are you proceeding" options:
   • Remand
   • Straight Reversal
7. On the "Which issues are being addressed by the court?" section of the form, do not check all the issues, only have some checked.
8. Fill out remaining info and click the "Submit" button
9. Login as an OCC and/or OAI team member.
10. On the "Your cases" page, click the "Search cases" link to be taken to the "Veteran Case Search" page
11. Search the veteran ID you used to create a CAVC Remand
12. Go into the source appeal case details page
13. Click on the CAVC Dashboard button
14. Click on the CAVC Dashboard tab that you just created.
15. Observe that all issues are present and not just the CAVC Appeal issue

Best practices

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

• RSpec
• Jest
• Other

Code Climate

Your code does not add any new code climate offenses? If so why?

• No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

• Are performance metrics (e.g., response time, throughput) being tracked?
• Are key application components monitored (e.g., database, cache, queues)?
• Is there a system in place for setting up alerts based on performance thresholds?

Logging

• Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
• Are logs structured (e.g., using log tags) for easier querying and analysis?
• Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
• Is log retention and rotation configured correctly?
• Are logs being forwarded to a centralized logging system if needed?

Auditing

• Are user actions being logged for audit purposes?
• Are changes to critical data being tracked ?
• Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

• Are errors being caught and handled gracefully?
• Are appropriate error messages being displayed to users?
• Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
• Are unhandled exceptions being caught at the application level ?

Exception Handling

• Are custom exceptions defined and used where appropriate?
• Is exception handling consistent throughout the codebase?
• Are exceptions logged with relevant context and stack trace information?
• Are exceptions being grouped and categorized for easier analysis and resolution?

[codeclimate]

Code Climate has analyzed commit 9ded555 and detected 0 issues on this pull request.

View more on Code Climate.