Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lthompson/APPEALS-25112 #19057

Merged
merged 24 commits into from
Aug 1, 2023
Merged

lthompson/APPEALS-25112 #19057

merged 24 commits into from
Aug 1, 2023

Conversation

lauren-e-thompson
Copy link
Contributor

@lauren-e-thompson lauren-e-thompson commented Jul 25, 2023 •
edited by mchbidwell
Loading

Resolves https://jira.devops.va.gov/browse/APPEALS-25112

Description

Value Statement:

As a caseflow developer I need to add radio buttons to the team management administrators page, so that I can assign hearings coordinators to be a pexip or a webex conference admin.

Acceptance Criteria

  • Code compiles correctly
  • Add Pexip & Webex radio buttons for each user displayed
  • Default selection of Pexip

Testing Plan

  • Radio buttons render correctly

Frontend Display

Previous master branch UI New changes to UI with radio buttons
Screenshot 2023-07-28 at 2 10 07 PM Screenshot 2023-07-28 at 3 28 37 PM

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@lauren-e-thompson lauren-e-thompson added the Team: Oumuamua ☄️ Development Team for the Hearings ART label Jul 25, 2023
@lauren-e-thompson lauren-e-thompson changed the base branch from feature/APPEALS-25109 to master July 26, 2023 17:49
@codeclimate
Copy link

codeclimate bot commented Jul 26, 2023 •
edited
Loading

Code Climate has analyzed commit 97bba81 and detected 0 issues on this pull request.

View more on Code Climate.

ThorntonMatthew
ThorntonMatthew reviewed Aug 1, 2023
View reviewed changes
app/models/user.rb Outdated Show resolved Hide resolved
ThorntonMatthew
ThorntonMatthew previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular work!

@ThorntonMatthew ThorntonMatthew changed the base branch from master to feature/APPEALS-25109 August 1, 2023 19:51
@ThorntonMatthew ThorntonMatthew dismissed their stale review August 1, 2023 19:51

The base branch was changed.

@ThorntonMatthew ThorntonMatthew merged commit a6c4afa into feature/APPEALS-25109 Aug 1, 2023
5 of 13 checks passed
@ThorntonMatthew ThorntonMatthew deleted the lthompson/APPEALS-25112 branch August 1, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorntonMatthew ThorntonMatthew ThorntonMatthew left review comments

@mchbidwell mchbidwell Awaiting requested review from mchbidwell

Assignees
No one assigned
Labels
Team: Oumuamua ☄️ Development Team for the Hearings ART
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lauren-e-thompson @ThorntonMatthew @breedbah @mchbidwell