-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
akonhilas/APPEALS-25136 #19107
Merged
Merged
akonhilas/APPEALS-25136 #19107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name, updated method to be more generic, changed pexip.rb to ruby style
Code Climate has analyzed commit cfd7400 and detected 0 issues on this pull request. View more on Code Climate. |
breedbah
reviewed
Aug 9, 2023
mchbidwell
approved these changes
Aug 14, 2023
mchbidwell
approved these changes
Aug 14, 2023
mchbidwell
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Refactor pexip_client to act as a facade for webex and pexip service
https://jira.devops.va.gov/browse/APPEALS-25136
Description
Value Statement:
As a Caseflow Developer, I need to create a ConferenceService and WebexClient, so that I can utilize the facade design pattern which provides a simplistic interface to the more detailed classes of PexipClient and WebexClient.
Acceptance Criteria
called (create_conference_job)
Testing Plan
Integrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling