Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/Appeals-25000 #19111

Merged
merged 18 commits into from
Aug 7, 2023
Merged

Min/Appeals-25000 #19111

merged 18 commits into from
Aug 7, 2023

Conversation

minhazur9
Copy link
Contributor

@minhazur9 minhazur9 commented Aug 2, 2023

Resolves APPEALS-25000

Description

Implement "Change task type", "Assign to person", "Assign to team", and "Cancel task" Task Actions

Acceptance Criteria

  • Code compiles correctly

When the user selects the Change task type action for a Hearing postponement request task, the following occurs:

  • The user is required to enter the following:
    Task type for the new task
    Available options include all task types other than Hearing postponement request
    Instructions and context
    Allowable characters include alphanumeric and special characters
    The user can cancel action to change task type at any time before submitting it
    The user can submit action to change the task type
  • Upon submitting the action, the following occurs:
    The Hearing postponement request task is cancelled
    “Currently active tasks” is updated to remove the cancelled task
    The Case Timeline is updated with an entry containing the following information:
    Cancelled on: < date Change task type action submitted >
    Event: “HearingPostponementRequestTask cancelled”
    Assigned to: < Caseflow Organization or user assigned to the task prior to its cancellation >
    Assigned by: < user who assigned the Hearing postponement request task to the above Caseflow Organization or user >
    Cancelled by: < user who submitted the Change task type action >
    Task instructions
  • The new task is added with the following attributes:
    Assigned on: < date Change task type action submitted >
    Assigned to: < Caseflow Organization or user assigned to the task >
    Assigned by: < user who submitted the Change task type action >
    Task: < task type of the new task >
    Task instructions: as specified in the attached wireframes
    The new task appears in the “Currently active tasks” section of the Case Details page

When the user selects the Assign to team action for a Hearing postponement request task, the following occurs:

  • The user is required to enter the following:
    The team to which the Hearing postponement request task will be assigned
    All teams are available for assignment
    Instructions and context
    Allowable characters include alphanumeric and special characters
    The user can cancel action to assign to team at any time before submitting it
    The user can submit action to assign to team
    Upon submitting the action, the following occurs:
  • A new HearingPostponementRequestMailTask is created whose parent is the original HPR task. Its attributes are set as follows:
    Assigned on: < date Assign to team action submitted >
    Assigned to: < Caseflow Organization assigned to the task >
    Assigned by: < user who submitted the Assign to team action >
    Task: remains “Hearing postponement request”
    Task instructions
    The updated task appears in the “Currently active tasks” section of the Case Details page

When the user selects the Assign to person action for a Hearing postponement request task, the following occurs:

  • The user is required to enter the following:
    The person to whom the Hearing postponement request task will be assigned
    Persons available for assignment are members of the currently assigned team
    Instructions and context
    Allowable characters include alphanumeric and special characters
    The user can cancel action to assign to person at any time before submitting it
    The user can submit action to assign to person
    Upon submitting the action, the following occurs:
  • The Hearing postponement request task attributes are updated as follows:
    Assigned on: < date Assign to person action submitted >
    Assigned to: < person assigned to the task >
    Assigned by: < user who submitted the Assign to person action >
    Task: remains “Hearing postponement request”
    Task instructions
    The updated task appears in the “Currently active tasks” section of the Case Details page

When the user selects the Cancel action for a Hearing postponement request task, the following occurs:

  • The user is required to enter the following:
    Instructions and context
    Allowable characters include alphanumeric and special characters
    The user can cancel action to cancel the task at any time before submitting it
    The user can submit action to cancel the task
    Upon submitting the action, the following occurs:
    The Hearing postponement request task is cancelled
    “Currently active tasks” is updated to remove the cancelled task
  • The Case Timeline is updated with an entry containing the following information:
    Cancelled on: < date Cancel action submitted >
    Event: “HearingPostponementRequestTask cancelled”
    Assigned to: < Caseflow Organization or user assigned to the task prior to its cancellation >
    Assigned by: < user who assigned the Hearing postponement request task to the above Caseflow Organization or user >
    Cancelled by: < user who submitted the Cancel action >
    Task instructions: as specified in the attached wireframes

Testing Plan

DEV Test
DEV Execution

CI=true bundle exec rspec spec/feature/queue/mail_task_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

MailTasks
  Assigning a mail team task to a team member
    when task is assigned to AOD team

All visited screens will be scanned for 508 accessibility compliance.
      successfully assigns the task to team member
  Changing a mail team task type
    should update the task type
  Hearing Postponement Request Mail Task
    assigning to new team
    assign to person
    changing task type
      current tasks should have new task
      case timeline should cancel old task
    cancelling task
      should remove HearingPostponementRequestTask from current tasks
      case timeline should cancel task

Finished in 58.19 seconds (files took 4.04 seconds to load)
8 examples, 0 failures

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

* feature/APPEALS-21339: (30 commits)
  updated deserialize method to check on rating decision model for attributes in hash
  Revert "Take setup-node for a spin"
  Take setup-node for a spin
  allow slack notifications in uat
  Update open_hearing_tasks_without_active_descendants_checker_spec.rb
  HunJerBAH APPEALS-26881: Reject Unknown Attributes in RatingDecisions Hash (#19072)
  hid mst pact special issues banner behind feature toggles
  updated back button routing and special issues showing on decisions for ama appeals
  routed judge/attorney decisions to special issues pending on mst pact toggle
  added toggle for mst on special issues list
  hid blue water and burn pit behind mst/pact toggle
  added 24 hr caching and commented out toggle for bgs call
  adding logging for BGS contention calls
  updated feature toggles to include current user
  added caching to BGS contention call
  hid pact and mst check behind toggles
  added feature toggle guard clause for bgs calls for ratings
  optimized participant contentions method to return contentions to cut down on BGS calls
  APPEALS-17497: MST & PACT Special issues identification
  added 24 hr caching and commented out toggle for bgs call
  ...
* feature/APPEALS-21339:
  exclude db/scripts in codeclimate (#19103)
  Craig/test yarn cache (#19096)
  test update to yarn dependency cache keys
  add exception handling to audit remove script
@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit ee758e3 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2

View more on Code Climate.

@minhazur9 minhazur9 changed the base branch from master to feature/APPEALS-21339 August 2, 2023 17:52
@msteele96 msteele96 changed the base branch from feature/APPEALS-21339 to msteele/APPEALS-24996 August 2, 2023 18:25
@msteele96 msteele96 changed the base branch from msteele/APPEALS-24996 to feature/APPEALS-21339 August 2, 2023 18:27
@msteele96 msteele96 changed the base branch from feature/APPEALS-21339 to msteele/APPEALS-24996 August 2, 2023 18:45
@msteele96 msteele96 changed the base branch from msteele/APPEALS-24996 to master August 2, 2023 18:46
@minhazur9 minhazur9 changed the base branch from master to feature/APPEALS-21339 August 2, 2023 20:09
minhazur9 and others added 3 commits August 2, 2023 16:10
…-affairs/caseflow into min/APPEALS-25000

* 'min/APPEALS-25000' of github.com:department-of-veterans-affairs/caseflow:
  Revert "APPEALS-17497: MST & PACT Special issues identification"
@minhazur9 minhazur9 changed the base branch from feature/APPEALS-21339 to master August 3, 2023 18:33
@minhazur9 minhazur9 changed the base branch from master to feature/APPEALS-21339 August 3, 2023 18:58
@minhazur9 minhazur9 marked this pull request as ready for review August 3, 2023 19:19
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ThorntonMatthew ThorntonMatthew merged commit 646156b into feature/APPEALS-21339 Aug 7, 2023
11 of 14 checks passed
@ThorntonMatthew ThorntonMatthew deleted the min/APPEALS-25000 branch August 7, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants