-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Min/Appeals-25000 #19111
Merged
Merged
Min/Appeals-25000 #19111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changing task types
* feature/APPEALS-21339: (30 commits) updated deserialize method to check on rating decision model for attributes in hash Revert "Take setup-node for a spin" Take setup-node for a spin allow slack notifications in uat Update open_hearing_tasks_without_active_descendants_checker_spec.rb HunJerBAH APPEALS-26881: Reject Unknown Attributes in RatingDecisions Hash (#19072) hid mst pact special issues banner behind feature toggles updated back button routing and special issues showing on decisions for ama appeals routed judge/attorney decisions to special issues pending on mst pact toggle added toggle for mst on special issues list hid blue water and burn pit behind mst/pact toggle added 24 hr caching and commented out toggle for bgs call adding logging for BGS contention calls updated feature toggles to include current user added caching to BGS contention call hid pact and mst check behind toggles added feature toggle guard clause for bgs calls for ratings optimized participant contentions method to return contentions to cut down on BGS calls APPEALS-17497: MST & PACT Special issues identification added 24 hr caching and commented out toggle for bgs call ...
Code Climate has analyzed commit ee758e3 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
msteele96
changed the base branch from
feature/APPEALS-21339
to
msteele/APPEALS-24996
August 2, 2023 18:25
msteele96
changed the base branch from
msteele/APPEALS-24996
to
feature/APPEALS-21339
August 2, 2023 18:27
msteele96
reviewed
Aug 2, 2023
msteele96
changed the base branch from
feature/APPEALS-21339
to
msteele/APPEALS-24996
August 2, 2023 18:45
…changing to itself from UI
…-affairs/caseflow into min/APPEALS-25000 * 'min/APPEALS-25000' of github.com:department-of-veterans-affairs/caseflow: Revert "APPEALS-17497: MST & PACT Special issues identification"
ThorntonMatthew
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-25000
Description
Implement "Change task type", "Assign to person", "Assign to team", and "Cancel task" Task Actions
Acceptance Criteria
When the user selects the Change task type action for a Hearing postponement request task, the following occurs:
Task type for the new task
Available options include all task types other than Hearing postponement request
Instructions and context
Allowable characters include alphanumeric and special characters
The user can cancel action to change task type at any time before submitting it
The user can submit action to change the task type
The Hearing postponement request task is cancelled
“Currently active tasks” is updated to remove the cancelled task
The Case Timeline is updated with an entry containing the following information:
Cancelled on: < date Change task type action submitted >
Event: “HearingPostponementRequestTask cancelled”
Assigned to: < Caseflow Organization or user assigned to the task prior to its cancellation >
Assigned by: < user who assigned the Hearing postponement request task to the above Caseflow Organization or user >
Cancelled by: < user who submitted the Change task type action >
Task instructions
Assigned on: < date Change task type action submitted >
Assigned to: < Caseflow Organization or user assigned to the task >
Assigned by: < user who submitted the Change task type action >
Task: < task type of the new task >
Task instructions: as specified in the attached wireframes
The new task appears in the “Currently active tasks” section of the Case Details page
When the user selects the Assign to team action for a Hearing postponement request task, the following occurs:
The team to which the Hearing postponement request task will be assigned
All teams are available for assignment
Instructions and context
Allowable characters include alphanumeric and special characters
The user can cancel action to assign to team at any time before submitting it
The user can submit action to assign to team
Upon submitting the action, the following occurs:
Assigned on: < date Assign to team action submitted >
Assigned to: < Caseflow Organization assigned to the task >
Assigned by: < user who submitted the Assign to team action >
Task: remains “Hearing postponement request”
Task instructions
The updated task appears in the “Currently active tasks” section of the Case Details page
When the user selects the Assign to person action for a Hearing postponement request task, the following occurs:
The person to whom the Hearing postponement request task will be assigned
Persons available for assignment are members of the currently assigned team
Instructions and context
Allowable characters include alphanumeric and special characters
The user can cancel action to assign to person at any time before submitting it
The user can submit action to assign to person
Upon submitting the action, the following occurs:
Assigned on: < date Assign to person action submitted >
Assigned to: < person assigned to the task >
Assigned by: < user who submitted the Assign to person action >
Task: remains “Hearing postponement request”
Task instructions
The updated task appears in the “Currently active tasks” section of the Case Details page
When the user selects the Cancel action for a Hearing postponement request task, the following occurs:
Instructions and context
Allowable characters include alphanumeric and special characters
The user can cancel action to cancel the task at any time before submitting it
The user can submit action to cancel the task
Upon submitting the action, the following occurs:
The Hearing postponement request task is cancelled
“Currently active tasks” is updated to remove the cancelled task
Cancelled on: < date Cancel action submitted >
Event: “HearingPostponementRequestTask cancelled”
Assigned to: < Caseflow Organization or user assigned to the task prior to its cancellation >
Assigned by: < user who assigned the Hearing postponement request task to the above Caseflow Organization or user >
Cancelled by: < user who submitted the Cancel action >
Task instructions: as specified in the attached wireframes
Testing Plan
DEV Test
DEV Execution
Tests
Test Coverage
Did you include any test coverage for your code? Check below: