Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reassign Case page Task(s) not displaying #19155

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

piedram
Copy link
Contributor

@piedram piedram commented Aug 9, 2023

Resolves APPEALS-24904, APPEALS-27506

Description

Task(s) to be cancelled do not display under the "The following task(s) will be cancelled" on the Reassign Case Page

Acceptance Criteria

  • Code compiles correctly
  • Task(s) to be cancelled will display under the "The following task(s) will be cancelled" on the Reassign Case Page

Testing Plan

  • Login to: Moon Walkers Demo Environment
  • Change user to BVARDUNKLE (VACO)
  • Select task action dropdown
  • On Reassign Case Page error is shown given task(s) are not displaying under the "The following task(s) will be cancelled"

imagen11

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 93e8271 and detected 62 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 28
Complexity 17
Style 17

View more on Code Climate.

@cacevesva cacevesva changed the base branch from master to feature/APPEALS-24914 August 11, 2023 15:50
@@ -11,7 +11,7 @@ import COPY from '../../COPY';
import { onReceiveAmaTasks } from './QueueActions';
import { requestSave, resetSuccessMessages, highlightInvalidFormItems } from './uiReducer/uiActions';
import { taskActionData } from './utils';
import { taskById, appealWithDetailSelector, allHearingTasksForAppeal } from './selectors';
import { taskById, appealWithDetailSelector, allHearingTasksForAppeal, getAllHiaringChildren } from './selectors';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of getAllHiraingChildren is suppose to be getAllHiringChildren?

@@ -259,6 +259,34 @@ export const getAttorneyTasksForJudgeTask = createSelector(
}
);

export const getAllHiaringChildren = createSelector(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of getAllHiraingChildren is suppose to be getAllHiringChildren?

@cacevesva cacevesva marked this pull request as ready for review August 15, 2023 14:48
@cacevesva cacevesva merged commit 21955ae into feature/APPEALS-24914 Aug 15, 2023
0 of 14 checks passed
@cacevesva cacevesva deleted the piedram/APPEALS-27506 branch August 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants