aedara/APPEALS-27848 Fix Deprecation Warning: The success? predicate is deprecated and will be removed in Rails 6.0
#19177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-27848
Description
Acceptance Criteria
Testing Plan
Local Development Environment
Allowed Deprecation Warning does NOT raise exception
development
Rails console, manually issue a test deprecation warningDisallowed Deprecation Warning raises exception
development
Rails console, manually issue the deprecation warningDisallowedDeprecationError
is raisedCI / Test Environment
Deprecation Warning is no longer emitted
spec/requests/health_checks_spec.rb
UAT
DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0 [...]
was createdDisallowedDeprecationError
was NOT created#appeals-deprecation-alerts
and confirm that a new alert was created forDEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0 [...]
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling