Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-23709 #19186

Merged
merged 3 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/unrecognized_appellants_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def unrecognized_appellant_params
def unrecognized_party_details
[
:party_type, :name, :middle_name, :last_name, :suffix, :address_line_1, :address_line_2, :date_of_birth,
:address_line_3, :city, :state, :zip, :country, :phone_number, :email_address
:address_line_3, :city, :state, :zip, :country, :phone_number, :email_address, :ein, :ssn
]
end
end
2 changes: 1 addition & 1 deletion app/models/concerns/has_unrecognized_party_detail.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module HasUnrecognizedPartyDetail
extend ActiveSupport::Concern

included do
delegate :name, :first_name, :middle_name, :last_name, :suffix, :ssn,
delegate :name, :first_name, :middle_name, :last_name, :suffix, :ein, :ssn,
:address, :address_line_1, :address_line_2, :address_line_3,
:city, :state, :zip, :country, :date_of_birth,
:phone_number, :email_address, :party_type,
Expand Down
2 changes: 1 addition & 1 deletion app/models/other_claimant.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Currently used for attorney fee cases when the attorney isn't found in the BGS attorney database.

class OtherClaimant < Claimant
delegate :name, :first_name, :middle_name, :last_name, :suffix, :ssn,
delegate :name, :first_name, :middle_name, :last_name, :suffix, :ein, :ssn,
:address, :address_line_1, :address_line_2, :address_line_3,
:city, :state, :zip, :country, :date_of_birth,
:email_address, :phone_number,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddEinToUnrecognizedPartyDetails < Caseflow::Migration
def change
add_column :unrecognized_party_details, :ein, :string, comment: "PII. Employer Identification Number"
end
end
3 changes: 2 additions & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2023_07_31_194341) do
ActiveRecord::Schema.define(version: 2023_08_14_133820) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -1749,6 +1749,7 @@
t.string "country", null: false
t.datetime "created_at", null: false
t.date "date_of_birth", comment: "PII"
t.string "ein", comment: "PII. Employer Identification Number"
t.string "email_address", comment: "PII"
t.string "last_name", comment: "PII"
t.string "middle_name", comment: "PII"
Expand Down
5 changes: 4 additions & 1 deletion spec/controllers/unrecognized_appellant_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
let(:updated_relationship) { "updated" }
let(:updated_address_1) { "updated_address_1" }
let(:updated_address_2) { "updated_address_2" }
let(:ein) { "1234567" }
let(:params) do
{
relationship: updated_relationship,
unrecognized_party_detail: {
address_line_1: updated_address_1,
address_line_2: updated_address_2
address_line_2: updated_address_2,
ein: ein
}
}
end
Expand Down Expand Up @@ -43,6 +45,7 @@
expect(response_body["relationship"]).to eq updated_relationship
expect(response_body["unrecognized_party_detail"]["address_line_1"]).to eq updated_address_1
expect(response_body["unrecognized_party_detail"]["address_line_2"]).to eq updated_address_2
expect(response_body["unrecognized_party_detail"]["ein"]).to eq ein

expect(ua.current_version.relationship).to eq updated_relationship
expect(ua.first_version.relationship).to eq original_relationship
Expand Down
Loading